Closed Bug 1026296 Opened 10 years ago Closed 10 years ago

[email] For cards in a build, language changes are not properly changed.

Categories

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::E-Mail
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: jrburke, Unassigned)

References

Details

(Whiteboard: [g+])

Bug 1005760 fixes the issue for DOM nodes that are not part of build. However, for builds, the tmpl_builder.js file will inline the HTML text and call tmpl.toDom: https://github.com/awiss/gaia/blob/master/apps/email/js/tmpl_builder.js#L207 Those nodes are not tracked by the node updates that happen in tmpl. So I suggest we create a tmpl.trackL10n() that accepts a node and adds it to the internal nodes array in tmpl. Steps to reproduce the failure: 1) Install email on a device, where the build runs. 2) Go to compose in email app. 3) Go to settings, change language 4) Switch back to email app, close compose so that now the message list is shown. 5) Go to settings, change the language again. 6) Go back to email and go to compose. The compose card will show the incorrect language.
Depends on: 1005760
Summary: [email] → [email] For cards in a build, language changes are not properly changed.
Whiteboard: [g+]
This is no longer an issue on master/2.1 since the mutation observer changes in l10n.js take care of it for us, so closing this out.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.