1026307 - Add "pa" to `product-details`

Status: RESOLVED FIXED

(Marketplace Graveyard :: General, defect)

Description

[Christopher Van Wiemeersch [:cvan]]

Punjabi is already "pa-IN" but Gaia treats it as "pa" so let's add that to `product-details`:

    http://svn.mozilla.org/libs/product-details/json/languages.json

Comment 1

[Francesco Lodolo [:flod]]

If you're look at Gaia locale codes, I'd say it's also missing "gu" for "gu-IN", and "sr-Cyrl".

Comment 2

[Wil Clouser [:clouserw]]

Hi Amanpreet.  Before I can update the locale files, I need to have the following string translated into Punjabi for India.  Can you translate this for me?  Thanks.  The string:

> Punjabi (India)

Comment 3

[Wil Clouser [:clouserw]]

Ankit - Would you translate the following into Gujarati please?

> Gujarati

> Gujarati (India)

Comment 4

[Wil Clouser [:clouserw]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> If you're look at Gaia locale codes, I'd say it's also missing "gu" for
> "gu-IN", and "sr-Cyrl".

The Gujarati is a good call out.  sr-Cyrl is simply sr, which brings up a good point.  I think I had this talk with Axel many months ago, but it seems like FirefoxOS is using different locale codes than the rest of Mozilla.  They're not wrong necessarily, they're just non-standard for what we've done in the past which means it's different from all our other projects (and potentially means adjusting automated tools and such).  For example, sr and sr-Latn have been our standard Serbian codes, I don't think we've ever used sr-Cyrl anywhere.  (See bug 380287 for some more conversation about pa vs pa-IN).

Axel, do you have any guidance here?  Adding them to localeDetails (this bug) is no big deal, but it could be confusing down the line if we don't have some standardization.

Comment 5

[Francesco Lodolo [:flod]]

sr-Cyrl is used on Gaia, so I assumed we wanted it in product-details.
https://github.com/mozilla-b2g/gaia/blob/master/locales/languages_all.json#L57-L58

Elsewhere, we just use "sr" for "Serbian" in Cyrillic, we also never managed Serbian in Latin script before Gaia.

Comment 6

[A S Alam]

(In reply to Wil Clouser [:clouserw] from comment #2)
> Hi Amanpreet.  Before I can update the locale files, I need to have the
> following string translated into Punjabi for India.  Can you translate this
> for me?  Thanks.  The string:
> 
> > Punjabi (India)

below is text in Punjabi
---
ਪੰਜਾਬੀ (ਭਾਰਤ)
----

thanks

Comment 7

[Ankit Patel]

(In reply to Wil Clouser [:clouserw] from comment #3)
> Ankit - Would you translate the following into Gujarati please?
> 
> > Gujarati
> 
> > Gujarati (India)

Gujarati - ગુજરાતી
Gujarati (India) - ગુજરાતી (ભારત)

Comment 8

[Wil Clouser [:clouserw]]

Thanks for the translations.  This is updated in r129753 and r129754.  Diff @ http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?r1=129753&r2=129752&pathrev=129753

I changed pa and gu but didn't adjust sr.  I'll needinfo Axel for details on that, but this bug, as filed, is fixed so closing.  Thanks.

Comment 9

[Axel Hecht [:Pike]]

sr-Cyrl and sr-Latn are standard locale codes, they're just not common. (Cyrl and Latn are standardized tags for Scripts, Cyrillic and Latin, resp)

Both are used in FxOS, so they'll surface in the marketplace realm, I guess. Not sure if there's overlap with product-details.

Comment 10

[Wil Clouser [:clouserw]]

Sure, but we haven't used sr-Cyrl before, just sr.  I'll add sr-Cyrl and we'll just have a dupe.  Thanks.