1026314 - Rename Key to CryptoKey in WebCrypto

Status: RESOLVED FIXED

(Core :: DOM: Security, defect)

Description

[Richard Barnes [:rbarnes]]

Per https://dvcs.w3.org/hg/webcrypto-api/rev/4673a7019d7f

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v2

Rebased due to some destructor fixes from bug 1028588.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

Rebased.

Comment 4

[Richard Barnes [:rbarnes]]

Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

Review of attachment 8449818 [details] [diff] [review]:
-----------------------------------------------------------------

Looks as straightforward as expected.  Thanks a lot!

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

Boris, can you please take a quick look at the IDL changes? I can't push this otherwise :) Thanks!

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

r=me on the IDL bits

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38831e922852

Comment 8

[Ed Morley [:emorley]]

Backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=43145908&tree=Mozilla-Inbound
211 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKeyPair to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
314 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKey to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
417 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Key should  be defined on the global scope
418 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | KeyPair should  be defined on the global scope
488 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | The following interface(s) are not enumerated: Key, KeyPair - got 2, expected 0
591 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKeyPair to all webpages as a property on the window (XBL: true)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
694 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKey to all webpages as a property on the window (XBL: true)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
797 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Key should  be defined on the XBL scope
798 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | KeyPair should  be defined on the XBL scope

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/225cc2ec2231

Comment 9

[Ed Morley [:emorley]]

(I'm guessing just some missing search and replace, but the tree had only just been reopened, so need to backout rather than wait for the followup, especially since there may be more than one)

Comment 10

[Tim Taubert [:ttaubert] (inactive)]

Attachment: 0002-Bug-1026314-Fix-DOM-interfaces-test.patch

Yeah, I missed that one test. Sorry.

https://tbpl.mozilla.org/?tree=Try&rev=5bf0213f40d4

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8451066 [details] [diff] [review]
0002-Bug-1026314-Fix-DOM-interfaces-test.patch

r=me

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dba3ded2ebc0

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/dba3ded2ebc0