Closed Bug 1026314 Opened 5 years ago Closed 5 years ago

Rename Key to CryptoKey in WebCrypto

Categories

(Core :: DOM: Security, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: rbarnes, Assigned: ttaubert)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 2 obsolete files)

Blocks: web-crypto
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8444734 - Flags: review?(rlb)
Rebased due to some destructor fixes from bug 1028588.
Attachment #8444734 - Attachment is obsolete: true
Attachment #8444734 - Flags: review?(rlb)
Attachment #8445716 - Flags: review?(rlb)
Rebased.
Attachment #8445716 - Attachment is obsolete: true
Attachment #8445716 - Flags: review?(rlb)
Attachment #8449818 - Flags: review?(rlb)
Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

Review of attachment 8449818 [details] [diff] [review]:
-----------------------------------------------------------------

Looks as straightforward as expected.  Thanks a lot!
Attachment #8449818 - Flags: review?(rlb) → review+
Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

Boris, can you please take a quick look at the IDL changes? I can't push this otherwise :) Thanks!
Attachment #8449818 - Flags: review?(bzbarsky)
Comment on attachment 8449818 [details] [diff] [review]
0001-Bug-1026314-Rename-Key-to-CryptoKey-in-WebCrypto.patch, v3

r=me on the IDL bits
Attachment #8449818 - Flags: review?(bzbarsky) → review+
Backed out for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=43145908&tree=Mozilla-Inbound
211 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKeyPair to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
314 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKey to all webpages as a property on the window (XBL: false)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
417 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Key should  be defined on the global scope
418 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | KeyPair should  be defined on the global scope
488 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | The following interface(s) are not enumerated: Key, KeyPair - got 2, expected 0
591 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKeyPair to all webpages as a property on the window (XBL: true)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
694 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | If this is failing: DANGER, are you sure you want to expose the new interface CryptoKey to all webpages as a property on the window (XBL: true)? Do not make a change to this file without a  review from a DOM peer for that specific change!!! (or a JS peer for changes to ecmaGlobals)
797 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | Key should  be defined on the XBL scope
798 INFO TEST-UNEXPECTED-FAIL | /tests/dom/tests/mochitest/general/test_interfaces.html | KeyPair should  be defined on the XBL scope

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/225cc2ec2231
(I'm guessing just some missing search and replace, but the tree had only just been reopened, so need to backout rather than wait for the followup, especially since there may be more than one)
Comment on attachment 8451066 [details] [diff] [review]
0002-Bug-1026314-Fix-DOM-interfaces-test.patch

r=me
Attachment #8451066 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/dba3ded2ebc0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.