1026346 - Please deploy server-syncstorage 1.5.6 through Production

Status: VERIFIED FIXED

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Ryan Kelly [:rfkelly]]

This version of syncstorage includes a change to the ORDER BY clause in bso selection queries, which allows them to make better use of the index.  Specifically:

    Bug 1025735 - Timestamp-sorted queries are "using filesort" rather than the index

I'm hopeful that this will help clean up some of the mysteriously-slow queries we're seeing in current prod.  It's a trivial change so we can get by with just a 30min sanity-check loadtest in stage.

Comment 1

[Ryan Kelly [:rfkelly]]

To be clear: this changes the app code to avoid using the "id" column in the ORDER BY clause.  It does not need (and we should not deploy) the change-what-columns-are-indexed change that was also suggested in Bug 1025735.

Comment 2

[Bob Micheletto [:bobm]]

1.5.6 has been deployed to Stage.

Comment 3

[James Bonacci [:jbonacci]]

OK, so for this release, Sync-1 and Sync-2 have been updated with rebuilt DBs based on request above.
Sync-3 and Sync-4 are the same as for release 1.5.5.

Going to run load tests (10min and 60min) across all four and record the overall differences (if any).

Comment 4

[Ryan Kelly [:rfkelly]]

> Sync-1 and Sync-2 have been updated with rebuilt DBs based on request above.
> Sync-3 and Sync-4 are the same as for release 1.5.5.

I believe that the db change was rolled back, and all four boxes now have the same db schema as was used in the 1.5.5 deploy.

Comment 5

[James Bonacci [:jbonacci]]

Ah, ok, so Sync-1 through Sync-4 are all the same and the patch from bug 1025735 has been applied globally.
REF: https://bugzilla.mozilla.org/show_bug.cgi?id=1025735#c11

Comment 6

[James Bonacci [:jbonacci]]

Remote integration tests ran as expected.
On to short load tests...

Comment 7

[James Bonacci [:jbonacci]]

10 minute load tests all looked good, but there was one addFailure for Sync-4:
https://loads.services.mozilla.com/run/7b6c76b7-1894-46e4-b19b-0b9cf55fdded

Running a 30min on Sync-4 now...

Comment 8

[James Bonacci [:jbonacci]]

I did not see any issues with the 30min on Sync-4:
https://loads.services.mozilla.com/run/a67e22a1-84c0-4b48-8dd6-75ea91dd33bc

Comment 9

[James Bonacci [:jbonacci]]

:bobm I am ok with this patch.
Let schedule the push to Production using this same ticket (because title)...

Comment 10

[James Bonacci [:jbonacci]]

See the following CW: 
https://mana.mozilla.org/wiki/display/SVCOPS/CW-20140619+-+Bobm

Comment 11

[Bob Micheletto [:bobm]]

This has been deployed to production.

Comment 12

[James Bonacci [:jbonacci]]

Awesome.