1026377 - [Sora]There is no highlight stripe when selecting some option in STK menu

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P2)

Description

[sync-1]

Mozilla build ID:20140422024003
 DEFECT DESCRIPTION:
 Phone doesn't present the blue highlight stripe effect when selecting a submenu inside STK menu in order to let user know that a submenu has been selected
 
  REPRODUCING PROCEDURES:
 1. Access phone settings then select STK menu (VIVO chip - at the end of list);
 2. Notice a lot of sub menus are presented;
 3. Select any submenu (e.g.: Promocoes e Pacotes, Vivo agenda);
 4. Notice when selecting some option, phone doesn't show the highligh stripe effect (just like the effect presented when selecting an option inside phone settings: e.g.: Call settings, Message settings or any other option);
 5. Notice user don't know if the submenu was selected or not, because there is no indication of this action.
 
 *Phone could present exactly the same blue highlight strip presented in phone setting menu.
 
  EXPECTED BEHAVIOUR:
 Phone must present a highlight stripe when selecting some option inside STK menu in order to let user know that an option has been selected
 
  ASSOCIATE SPECIFICATION:
 None
 
  TEST PLAN REFERENCE:
 pre homo VIVO
 
  TOOLS AND PLATFORMS USED:
 STK menu
 
  USER IMPACT:
 Will see and maybe will be confused
 
  REPRODUCING RATE:
 100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[xiaokang.chen]

Dear Fernando,
I know little about the gaia code, can you provide a proposed patch for this?

Thanks a lot!

Comment 2

[xiaokang.chen]

Dear Fernando,
Can you have a look at this. Thanks a lot!

Comment 3

[xiaokang.chen]

Dear All,
This is a block case for VIVO.

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=a7e7b52a63d6804768ca4602f0c96191a736188e

Comment 6

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Cert blocker for TEF LATAM

Comment 7

[xiaokang.chen]

Dear All,
I have tested the patch in XI'AN. It's OK now.

Thanks a lot @ Fernando.

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Same patch for v1.3

Comment 9

[howie [:howie]]

assign Fernando as the owner, thanks

Comment 10

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8446004 [details] [review]
Same patch for v1.3

I'm not going to review this 1.3 patch. The reason to have this attached is to check whether everything is fine on 1.3 branch once this patch is applied.

Still waiting to see this passing.

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Travis is failing but not for this patch.

Master patch is "green"
v1.3 is still running

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #8)
> Created attachment 8446004 [details] [review]
> Same patch for v1.3

Travis didn't pass. Have a look a it please.

Comment 13

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to José Antonio Olivera Ortega [:jaoo] from comment #12)
> (In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from
> comment #8)
> > Created attachment 8446004 [details] [review]
> > Same patch for v1.3
> 
> Travis didn't pass. Have a look a it please.

Error is out of the scope of this bug :(

 1) [communications-contacts] contacts/navigation should send show-navbar to dialer when leaving view-contact-form:
TypeError: Attempted to wrap undefined property postMessage as function
at wrapMethod (http://test-agent.gaiamobile.org:8080/common/vendor/sinon/sinon.js:522:1)
at spy (http://test-agent.gaiamobile.org:8080/common/vendor/sinon/sinon.js:1080:9)
at spy (http://test-agent.gaiamobile.org:8080/common/vendor/sinon/sinon.js:2490:13)
at (anonymous) (http://communications.gaiamobile.org:8080/contacts/test/unit/navigation_test.js:277:9)
at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081:5)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127:7)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007:7)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016:7)
at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964:16)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)

Should we fix this too?

Comment 14

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Rik, Travis is failing in 1.3 due to some tests failing out of the scope of this trivial patch. Can we land into this conditions?

Comment 15

[Anthony Ricaud (:rik)]

Thanks for asking! Can you show me a 1.3 build with this test failing before your patch?

Comment 16

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Anthony Ricaud (:rik) from comment #15)
> Thanks for asking! Can you show me a 1.3 build with this test failing before
> your patch?

Thanks Rik.

If you look for any 1.3 build here [1] you will see the same error in communications-contacts, for example in this one [2]

[1] https://travis-ci.org/mozilla-b2g/gaia/builds
[2] https://travis-ci.org/mozilla-b2g/gaia/builds/28531108

Comment 17

[Anthony Ricaud (:rik)]

Cool. Clear for landing then.

Comment 18

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8443321 [details] [review]
Proposed patch

(In reply to Anthony Ricaud (:rik) from comment #17)
> Cool. Clear for landing then.

Well, It seems we can land this. Please Fernando, land at will. r=me

Sorry for the noise and thanks for taking care of it.

Comment 19

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed.

Master: https://github.com/mozilla-b2g/gaia/commit/d7a517f0bde32072f1799e4a47ea34c6d786c287
V1.3: https://github.com/mozilla-b2g/gaia/commit/e08beb0297aff472b5c84437e9d7eaf8c0400a29

Comment 20

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/8bad8ca51d5ffc3b14b69effc49b5234353795c0
v1.4: https://github.com/mozilla-b2g/gaia/commit/9ec45071c9c6bf921061580363257907e0465e16

Comment 21

[Loli (:lolimartinezcr)]

Attachment: 2014-08-12-04-06-15.png

Comment 22

[Loli (:lolimartinezcr)]

Attachment: 2014-08-12-04-06-30.png

Comment 23

[Loli (:lolimartinezcr)]

 Tested and working (see attached image)
Hamachi
2.1
Gecko-329b2e4
Gaia-d688d4f

2.0
Gecko-d7d9838
Gaia-1144cdc