1026453 - Ensure Loop's panel layout looks good in the Application Menu

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect, P5)

Description

[Mark Banner (:standard8)]

Attachment: Bad layout

Bug 1011392 enables the panel to work in the application window, but the different size means the panel layout doesn't look as good as it should, hence we should fix that.

Comment 2

[Romain Testard [:RT]]

For info I discussed the need for UX with Darrin and the proposed way forward is to use the existing UX with slightly smaller width. We can revisit and if this brings issues.

Comment 3

[:shell escalante]

UX is updated for size - revisit if still don't like

Comment 5

[Mark Banner (:standard8)]

From bug 1053476:

When the Loop button is placed in the Hamburger menu it reveals a panel which has a lot of wasted vertical space. It would be better for this sub-panel to be dynamically sized to the content. I'll attach a couple of screenshots.

Comment 6

[Mike de Boer [:mikedeboer]]

It doesn't look as bad anymore as the screenshot tries to tell us, but the Loop panel contents still needs to be stretched to the subviews' full height so that the footer will truly be a footer :)

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

This isn't high priority since bug 1047316 removed the subview view and switched to using the panel when Loop is clicked on from the Firefox menu.

We won't need to fix this bug until bug 1057472 is fixed.

Comment 8

[Ian Bicking (:ianbicking)]

Sevaan: can you check if there's something more here to be done?

Comment 9

[Sevaan Franks [:sevaan]]

If I move the icon to the menu and click it, the panel opens from the top-left of the browser, which is not good.

Could we have it so that if you click on the Hello icon if it is in the menu, the menu closes and the Hello panel hangs from the hamburger menu?

Comment 10

[Ian Bicking (:ianbicking)]

Sevaan: can you open a new ticket that describes what you say, and mark this ticket as a duplicate of that ticket?

Comment 12

[Mark Banner (:standard8)]

(In reply to Sevaan Franks [:sevaan] from comment #9)
> If I move the icon to the menu and click it, the panel opens from the
> top-left of the browser, which is not good.

This is actually, a slightly different (and badly described bug).

The bug here is that originally when in the menu, we were acting as a slide-in panel, similar to the "developer" button. This bug was to make sure we looked good there.

However, there were various bugs that made us revert it to the "open panel separately" style that we see today.

So, should we aim to be a slide-in panel (once we've fixed the other issues, bug 1057472, or can we continue as we are today (with the position fix)?

Comment 13

[Sevaan Franks [:sevaan]]

> So, should we aim to be a slide-in panel (once we've fixed the other issues,
> bug 1057472, or can we continue as we are today (with the position fix)?

Position fix, please. The slide-in panel will not be necessary when we switch to a sidebar experience.

Comment 14

[Mark Banner (:standard8)]

I'm a little surprised by the side-bar for everything, but anyway... lets go with wontfix for now.