1026454 - Fire PropertyChanged when discovery state changes

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect)

Description

[Ben Tian (inactive)]

PropertyChanged of BluetoothAdapter should be fired when discovery state changes.

Comment 1

[Ben Tian (inactive)]

Attachment: WIP patch 1/2: Fire PropertyChanged when discovery state changes

Comment 2

[Ben Tian (inactive)]

Attachment: WIP patch 2/2: Add macro to distribute BluetoothSignal on main thread

Comment 3

[Ben Tian (inactive)]

Attachment: Patch 1 (v2): Fire PropertyChanged when discovery state changes

Changes:
- Fire PropertyChanged when discovery state changes
- Revise macro BT_APPEND_NAMED_VALUE to handle atomic variables
- set mState=Disabled in BluetoothAdapter
- clean compilation warning by setting MOZ_FINAL.

Comment 4

[Eric Chou [:ericchou] [:echou]]

Comment on attachment 8442004 [details] [diff] [review]
Patch 1 (v2): Fire PropertyChanged when discovery state changes

Review of attachment 8442004 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with nits addressed.

::: dom/bluetooth2/bluedroid/BluetoothServiceBluedroid.cpp
@@ +155,5 @@
>      BT_APPEND_NAMED_VALUE(props, "Name", sAdapterBdName);
>      BT_APPEND_NAMED_VALUE(props, "Address", sAdapterBdAddress);
> +    if (sAdapterDiscoverable) {
> +      sAdapterDiscoverable = false;
> +      BT_APPEND_NAMED_VALUE(props, "Discoverable", sAdapterDiscoverable);

I would prefer using a constant instead of a variable in such case to avoid potential access to the variable, especially when sAdapterDiscoverable and sAdapterDiscovering are Atomic<bool> which may take time to lock/unlock.

@@ +583,5 @@
> +
> +    BluetoothSignal signal(NS_LITERAL_STRING("PropertyChanged"),
> +                           NS_LITERAL_STRING(KEY_ADAPTER), props);
> +    BluetoothService* bs = BluetoothService::Get();
> +    NS_ENSURE_TRUE(bs, NS_ERROR_FAILURE);

Please do this check at the beginning of the function so that we can save some time if bs is null.

Comment 5

[Ben Tian (inactive)]

Attachment: [final] Patch 1: Fire PropertyChanged when discovery state changes, r=echou

Comment 6

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/597a15e183a4

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/597a15e183a4