1026469 - tbpl marks spurious errors about pthread.h

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Marty Rosenberg [:mjrosenb]]

Attachment: getParsedLog.php?id=41848924

When there are build errors on windows (particularly, if there is a single error), it can get lost in the noise of multiple highlighted configure errors about missing pthread.h

Comment 1

[Mike Hommey [:glandium]]

Attachment: Use AC_CHECK_LIB instead of MOZ_CHECK_PTHREADS

MOZ_CHECK_PTHREADS was added in 2001, mentioning something about hpux and aix. I'm pretty sure even then, using AC_CHECK_LIB would have been fine.

Comment 2

[Mike Hommey [:glandium]]

Attachment: Use AC_CHECK_LIB instead of MOZ_CHECK_PTHREADS

Same for NSPR.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Skip compiler checks when using MSVC, even when $CC is not literally "cl"

Another dimension of the problem is that the nspr build system explicitly disables checks when using msvc. Except it only does so when $CC is exactly "cl". Which excludes try, where CC is cl, wrapped with sccache. I'm pretty sure (some) developers are setting CC manually too, to include a full path to cl.

Comment 4

[Ed Morley [:emorley]]

Thank you for doing this :-)

Comment 5

[Mike Hommey [:glandium]]

Ted, could you land this?

Comment 6

[(not currently active) Ted Mielczarek]

http://hg.mozilla.org/projects/nspr/rev/1d7d0bdaf77d
http://hg.mozilla.org/projects/nspr/rev/e40f25162a68

Comment 7

[(not currently active) Ted Mielczarek]

I tagged NSPR head as NSPR_4_10_7_BETA1 as well.

Comment 8

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/869cfa421fa9
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7e2e97d2355

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/869cfa421fa9
https://hg.mozilla.org/mozilla-central/rev/e7e2e97d2355