Closed Bug 1026473 Opened 6 years ago Closed 6 years ago

[Contacts][Refactor] Implement the Global Contacts Datastore data management module

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.1 fixed)

RESOLVED FIXED
2.0 S6 (18july)
Tracking Status
b2g-v2.1 --- fixed

People

(Reporter: jmcf, Assigned: jmcf)

References

Details

(Whiteboard: [p=2])

Attachments

(1 file)

No description provided.
The idea is to implement and land the GlobalContactsDatastore manager that will implement the following operations, among others:

init
add
get
remove
clear
Assignee: nobody → jmcf
Blocks: 968098
Target Milestone: --- → 2.0 S5 (4july)
Will this handle the passive merging of contacts?
Yes, the idea is to land the module you wrote weeks ago improved with calls to the contacts matcher in order to determine when a new entry should be merged with an existing one
Whiteboard: [p=6]
Attached file 21178.html
Attachment #8447947 - Flags: review?(francisco)
Comment on attachment 8447947 [details]
21178.html

Did a first pass, left some comments on github.

The creation and maintenance of the indexes is getting complicated, but I guess we need to deal with that problem.

Also thinking how much can this grow into memory, we will need to take that into account as well, with bug 1031306 we are suppose to check how much memory do we need for this index and 2000 contacts.
Attachment #8447947 - Flags: review?(francisco)
Attachment #8447947 - Flags: review?(francisco)
Comment on attachment 8447947 [details]
21178.html

Ok to land, and revisit after the performance investigations.


Thanks Jose, this is an excellent job!
Attachment #8447947 - Flags: review?(francisco) → review+
Target Milestone: 2.0 S5 (4july) → 2.0 S6 (18july)
Whiteboard: [p=6] → [p=2]
https://github.com/mozilla-b2g/gaia/commit/ca0bca3adc71de63df8de77cfa58fcbf87a0fbfb
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.