1026473 - [Contacts][Refactor] Implement the Global Contacts Datastore data management module

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Jose Manuel Cantera]

The idea is to implement and land the GlobalContactsDatastore manager that will implement the following operations, among others:

init
add
get
remove
clear

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Will this handle the passive merging of contacts?

Comment 3

[Jose Manuel Cantera]

Yes, the idea is to land the module you wrote weeks ago improved with calls to the contacts matcher in order to determine when a new entry should be merged with an existing one

Comment 4

[Jose Manuel Cantera]

Attachment: 21178.html

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8447947 [details]
21178.html

Did a first pass, left some comments on github.

The creation and maintenance of the indexes is getting complicated, but I guess we need to deal with that problem.

Also thinking how much can this grow into memory, we will need to take that into account as well, with bug 1031306 we are suppose to check how much memory do we need for this index and 2000 contacts.

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8447947 [details]
21178.html

Ok to land, and revisit after the performance investigations.


Thanks Jose, this is an excellent job!

Comment 7

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/ca0bca3adc71de63df8de77cfa58fcbf87a0fbfb