Closed Bug 1026510 Opened 11 years ago Closed 10 years ago

TAB Window cannot be closed

Categories

(Firefox :: Tabbed Browser, defect)

31 Branch
x86
Windows XP
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: chenzx, Unassigned)

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release) Build ID: 20140610163407 Steps to reproduce: I try to close a TAB window, using Ctrl+W, or Right click Actual results: The selected TAB window seems can not be closed
BTW, before that, I killed a "rundll32.exe" in my process manager, does that matter to this? that is to say, the "rundll32.exe" I killed is just Firefox's tab manager process?
Do you have tab mix plus installed?
Flags: needinfo?(chenzx)
NO, I have no addons nor plugins installed. After I close and restart Firefox, everything goes OK. So there MUST be some IPC problems in the tab manager code, i guess...
Flags: needinfo?(chenzx)
This problem occurs again This time i noticed that FF required restart to apply update, but i've ignored it. BTW, I always let FF run a whole month non-close-nor-restart-my-laptop.
Component: Untriaged → Tabbed Browser
Hi! I have the same problem. I tried to reproduce it with safe mode and all plugins disabled + with a new profile. This bug reproduces quite rarely so I tried for a week to use Firefox just to catch this bug with all the addons disabled and I could not see the bug. I cannot be sure that it is due to a plugin or not. It happens for a lot of moths now, one a few weeks or so. I run Firefox Developer Edition on Ubuntu 14.04 and Arch GNU/Linux and it happened on both. Today I fired up the browser toolbox and inspected two tabs: one that is broken and cannot be closed (2nd in my Firefox window, 1st from the print screen top to bottom) and another one that is a normal tab that can be closed (third in my FF page but second in the print screen). How can I provide more information the next time this happens. I am willing to compile FF with a patch if one is provided. Check out the print screen.
Firefox tab2 cannot be closed, tab3 can be closed
I don't think I was clear, I tried to reproduce the bug in safe mode but I could not. The print screen is from a FF with my profile and with plugins :( I cannot be sure if it is due to a plugin or if it is a FF bug. I sue Ctrl+W a lot to close windows.
(In reply to andrei from comment #6) > Hi! I have the same problem. I tried to reproduce it with safe mode and all > plugins disabled + with a new profile. This bug reproduces quite rarely so I > tried for a week to use Firefox just to catch this bug with all the addons > disabled and I could not see the bug. I cannot be sure that it is due to a > plugin or not. It happens for a lot of moths now, one a few weeks or so. > > I run Firefox Developer Edition on Ubuntu 14.04 and Arch GNU/Linux and it > happened on both. Today I fired up the browser toolbox and inspected two > tabs: one that is broken and cannot be closed (2nd in my Firefox window, 1st > from the print screen top to bottom) and another one that is a normal tab > that can be closed (third in my FF page but second in the print screen). How > can I provide more information the next time this happens. > > I am willing to compile FF with a patch if one is provided. Check out the > print screen. From this description, it's not clear to me which of the two tabs in the screenshot is the one that cannot be closed. Regardless, the markup looks the same from what I can tell... Are there any errors in the browser console if you try to close the tab and it doesn't close? Can you try using the browser debugger and setting a breakpoint in "_removeTab" in tabbrowser.xml, and see why it's not doing anything when you hit ctrl-w ? (make sure the breakpoint is also hit for tabs that do still close, and see e.g. bug 1113209 if it doesn't work at all... you might need to add a debugger; keyword with a patch to that file to make the debugging work)
Flags: needinfo?(andrei)
In the page inspector the first one cannot be closed and the second one can be closed. I did not think to check the developer console, I will check it next time. The problem is the fact that I cannot jump on that tab, it cannot be selected with Ctrl+Tab/Ctrl+Shift+Tab or with Click. I cannot hit Ctrl+W on that tab since it cannot be selected. I usually close lots of tabs with Ctrl+W and I hit it several times and once in a while one cannot be closed and it stays like this. I will set a breakpoint where you told me. Where can I set a breakpoint to see when tabs become selected? I will post more information next time this happens. Chen Zhixiang do you have a similar problem as me? Do the tabs not only become unclosable but also unselectable?
Flags: needinfo?(andrei)
(In reply to andrei from comment #10) > In the page inspector the first one cannot be closed and the second one can > be closed. > > I did not think to check the developer console, I will check it next time. > The problem is the fact that I cannot jump on that tab, it cannot be > selected with Ctrl+Tab/Ctrl+Shift+Tab or with Click. I cannot hit Ctrl+W on > that tab since it cannot be selected. I usually close lots of tabs with > Ctrl+W and I hit it several times and once in a while one cannot be closed > and it stays like this. So this is valuable information, because not being able to select the tab makes a difference to the potential reasons why closing doesn't work... > > I will set a breakpoint where you told me. Where can I set a breakpoint to > see when tabs become selected? Potentially here but I'm not sure: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#2608 > I will post more information next time this happens. Thank you! Please needinfo me in that case. :-) ("Need more information from...")
> So this is valuable information, because not being able to select the tab > makes a difference to the potential reasons why closing doesn't work... I'm starting to think this is not the same issue that Chen Zhixiang reported. I tried a "need info" from the reporter but his account seems disabled.
I managed to reproduce the bug right now. Here is a video http://youtu.be/Q5OkbTdkFx0 It's 1080p and in the bottom right you can see the keys that I'm pressing. I will go to IRC on #firefox to try to debug this further since I have some time. In the video the third and forth tabs cannot be selected and closed.
Since I switched to e10s on FF Nightly and DevEdition this did not happen anymore. This can be marked as resolved.
(In reply to andrei from comment #14) > Since I switched to e10s on FF Nightly and DevEdition this did not happen > anymore. This can be marked as resolved. Thanks for letting us know!
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: