1026524 - update and final verify are incompatible with balrog

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[[e-mail] (:bhearsum)]

Update verify tests use an ancient style of update URL, eg:
https://aus4.mozilla.org/update/1/Firefox/31.0/20140610163407/Darwin_x86_64-gcc3-u-i386-x86_64/ach/betatest/update.xml?force=1

We should probably update them to use version 3 of the URL.

Comment 1

[[e-mail] (:bhearsum)]

For my multiple partial testing, I'm using the following:
diff --git a/release/updates/verify.sh b/release/updates/verify.sh
--- a/release/updates/verify.sh
+++ b/release/updates/verify.sh
@@ -110,10 +110,10 @@ do
       then
         if [ "$runmode" == "$TEST_ONLY" ]
         then
-          download_mars "${aus_server}/update/1/$product/$release/$build_id/$platform/$locale/$channel/update.xml?force=1" $patch_type 1
+          download_mars "${aus_server}/update/3/$product/$release/$build_id/$platform/$locale/$channel/default/default/default/update.xml?force=1" $patch_type 1
           err=$?
         else
-          download_mars "${aus_server}/update/1/$product/$release/$build_id/$platform/$locale/$channel/update.xml?force=1" $patch_type
+          download_mars "${aus_server}/update/3/$product/$release/$build_id/$platform/$locale/$channel/default/default/default/update.xml?force=1" $patch_type
           err=$?
         fi
         if [ "$err" != "0" ]; then


We might want something better for the first "default", which is supposed to be OS Version.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: modernize update verify URLs

I did a quick sanity check of this by comparing
https://aus3.mozilla.org/update/3/Firefox/31.0/20140610163407/Linux_x86-gcc3/ach/betatest/default/default/default/update.xml?force=1 and https://aus3.mozilla.org/update/1/Firefox/31.0/20140610163407/Linux_x86-gcc3/ach/betatest/update.xml?force=1

It's pretty trivial and safe, right? :)

I ended up leaving OS Version as "default" because we don't have any legitimate OS versions handy, and I thought that putting build target in that field would be more confusing than helpful.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8441411 [details] [diff] [review]
modernize update verify URLs

r+ if you make the matching changes to final-verification.sh.

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

Bug 1026827 to handle update/1/ in Balrog.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: modernize final verify urls, too

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8442072 [details] [diff] [review]
modernize final verify urls, too

Sheep it.