update and final verify are incompatible with balrog

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Update verify tests use an ancient style of update URL, eg:
https://aus4.mozilla.org/update/1/Firefox/31.0/20140610163407/Darwin_x86_64-gcc3-u-i386-x86_64/ach/betatest/update.xml?force=1

We should probably update them to use version 3 of the URL.
(Assignee)

Comment 1

3 years ago
For my multiple partial testing, I'm using the following:
diff --git a/release/updates/verify.sh b/release/updates/verify.sh
--- a/release/updates/verify.sh
+++ b/release/updates/verify.sh
@@ -110,10 +110,10 @@ do
       then
         if [ "$runmode" == "$TEST_ONLY" ]
         then
-          download_mars "${aus_server}/update/1/$product/$release/$build_id/$platform/$locale/$channel/update.xml?force=1" $patch_type 1
+          download_mars "${aus_server}/update/3/$product/$release/$build_id/$platform/$locale/$channel/default/default/default/update.xml?force=1" $patch_type 1
           err=$?
         else
-          download_mars "${aus_server}/update/1/$product/$release/$build_id/$platform/$locale/$channel/update.xml?force=1" $patch_type
+          download_mars "${aus_server}/update/3/$product/$release/$build_id/$platform/$locale/$channel/default/default/default/update.xml?force=1" $patch_type
           err=$?
         fi
         if [ "$err" != "0" ]; then


We might want something better for the first "default", which is supposed to be OS Version.
(Assignee)

Comment 2

3 years ago
Created attachment 8441411 [details] [diff] [review]
modernize update verify URLs

I did a quick sanity check of this by comparing
https://aus3.mozilla.org/update/3/Firefox/31.0/20140610163407/Linux_x86-gcc3/ach/betatest/default/default/default/update.xml?force=1 and https://aus3.mozilla.org/update/1/Firefox/31.0/20140610163407/Linux_x86-gcc3/ach/betatest/update.xml?force=1

It's pretty trivial and safe, right? :)

I ended up leaving OS Version as "default" because we don't have any legitimate OS versions handy, and I thought that putting build target in that field would be more confusing than helpful.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #8441411 - Flags: review?(nthomas)
Comment on attachment 8441411 [details] [diff] [review]
modernize update verify URLs

r+ if you make the matching changes to final-verification.sh.
Attachment #8441411 - Flags: review?(nthomas) → review+
Bug 1026827 to handle update/1/ in Balrog.
(Assignee)

Comment 5

3 years ago
Created attachment 8442072 [details] [diff] [review]
modernize final verify urls, too
Attachment #8441411 - Attachment is obsolete: true
Attachment #8442072 - Flags: review?(nthomas)
(Assignee)

Updated

3 years ago
Summary: update verify is incompatible with balrog → update and final verify are incompatible with balrog
Comment on attachment 8442072 [details] [diff] [review]
modernize final verify urls, too

Sheep it.
Attachment #8442072 - Flags: review?(nthomas) → review+
(Assignee)

Updated

3 years ago
Attachment #8442072 - Flags: checked-in+
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.