1026528 - [Messages] Corrupted attachments do not display correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

Attachment: 2014-06-17-16-46-39.png

Visual refresh regression, see attachment: the "corrupted" image is not located at the correct location.

Comment 1

[Oleg Zasypkin [:azasypkin]]

I'll take it.

Comment 2

[Julien Wajsberg [:julienw]]

Probably the regressing bug is bug 951687. Let's save QA time :)

Comment 3

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

Hey Julien, it's simple patch to fix the issue + I've moved "corrupted" class to the ".attachment" node as it's more appropriate place for it.

Also I'll try to find bug that broke it and add to the bug :)

Comment 4

[Julien Wajsberg [:julienw]]

Comment on attachment 8441917 [details] [review]
GitHub pull request URL

r=me

please squash before merging :)
thanks for the quick fix !

Comment 5

[Oleg Zasypkin [:azasypkin]]

master: https://github.com/mozilla-b2g/gaia/commit/96b5181a3985fa2d2c915a3315693c0bcba9c1a9

Comment 6

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/5a73f996e265349635d4d76fb224a6abf8155a97

Comment 7

[SandKing]

Hi Julien,
Would you please tell me how to receive MMS with corrupted attachments?
Thanks!

Comment 8

[Julien Wajsberg [:julienw]]

I'm not sure how to do it with a Firefox OS phone.

The idea is to send an incorrect image (you can take a real image, edit it in a text editor, and remove or replace a character in the middle of the file). But I don't think we can do this from Firefox OS because I think the gallery would not let you select the file, and we currently don't have a way to pick any file.

However maybe you can do this with a different OS, like Android or iPhone.

Comment 9

[SandKing]

This issue has been verified successfully on Flame2.1&2.0
Verify video:"verify_1026528.mp4".

Flame2.1 build:
Gaia-Rev        db2e84860f5a7cc334464618c6ea9e92ff82e9dd
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/211eae88f119
Build-ID        20141126001202
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141126.033519
FW-Date         Wed Nov 26 03:35:30 EST 2014
Bootloader      L1TC00011880

Flame2.0 bulid:
Gaia-Rev        824a61cccec4c69be9a86ad5cb629a1f61fa142f
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/acde07cb4e4d
Build-ID        20141125040209
Version         36.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141125.113029
FW-Date         Tue Nov 25 11:30:43 EST 2014
Bootloader      L1TC00011880

Comment 10

[SandKing]

Attachment: Verify video: verify_1026528.mp4