1026575 - [B2G][SMS] Message preview in Messages app thread view disappears after opening app

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Brogan Zumwalt [Inactive]]

Attachment: Logcat

Description:
When user opens Messages app with existing SMS messages, the content preview in thread view appears briefly before vanishing. This only occurs when a message thread has a single outbound message. Issue will not occur with two outbound messages, one inbound message, or any mixture of inbound and outbound messages. Issue will occur on a thread with one outbound message among other threads with both inbound and outbound messages. Opening message then returning to thread view causes text preview to persist, but this issue will occur again once user closes then reopens app.


Repro Steps:
1) Update a Flame to 20140617000201
2) Have an existing SMS thread with one outbound message (no inbound messages in same thread)
3) Launch Messages app

Actual:
Content preview for message thread with one outbound message disappears.

Expected:
Content preview is shown for all message threads.

Environmental Variables:
Device: Flame 2.0
Build ID: 20140617000201
Gaia: 0f254c92bc44d614ae56a855f18a895a7e4703ad
Gecko: 7f309a3a4d3d
Version: 32.0a2 (2.0) 
Firmware Version: v121-2

User Agent: Mozilla/5.0 (Mobile; rv32.0) Gecko/32.0 Firefox/32.0

Notes:
Repro frequency: 3/3, 100%
See attached: Youtube video clip & logcat
Youtube Link: http://youtu.be/axBx0AFopoU

Comment 1

[Brogan Zumwalt [Inactive]]

Issue does NOT occur on Flame 1.4

Result: Content preview is shown for all message threads.

Environmental Variables:
Device: Flame 1.4
Build ID: 20140617000202
Gaia: 4b3428e85b428e577a0f96cba6121c4ca1c91f8a
Gecko: ba55b5a7b20d
Version: 30.0 (1.4) 
Firmware Version: v121-2

Leaving QA Wanted for testing on other branches

Comment 2

[Natalya Kot [:nkot]]

This issue also reproduces on trunk, so going to find regression window there

Flame
BuildID: 20140618040513
Gaia: 431aed0a7c7560c6eacd35ea69aa0a7a4ebe72c7
Gecko: 37f08ddaea48
Version: 33.0a1
V121-1

Comment 3

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: blocker as it's a regression

Comment 4

[Oleg Zasypkin [:azasypkin]]

Hey Natalya,

Did you have chance to find regression window for this issue?

Thanks!

Comment 5

[Natalya Kot [:nkot]]

(In reply to Oleg Zasypkin [:azasypkin] from comment #4)
> Hey Natalya,
> 
> Did you have chance to find regression window for this issue?
> 
> Thanks!

Sorry, I've been busy with other stuff, passing this bug to Jayme.

Jayme: 
using tinderbox central builds
20140530013001 - the bug Does Reproduce
20140520073014 - the bug does NOT reproduce

Please narrow down further, thanks!!

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

There was a large gap in builds during this window on the Flame device.  As this issue does reproduce on Buri the window was completed there instead.

B2g-inbound Regression Window

Last working 
Environmental Variables:
Device: Buri Master
BuildID: 20140526003920
Gaia: 93470dbfe4212c020857bccdcb79cb16e2fafda3
Gecko: 3e839e1fe767
Version: 32.0a1 (Master) 
Firmware Version: v1.2device.cfg

First Broken 
Environmental Variables:
Device: Buri Master
BuildID: 20140526015622
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: f107c585cbc0
Version: 32.0a1 (Master) 
Firmware Version: v1.2device.cfg

Last working gaia / First broken gecko - Issue does NOT occur
Gaia: 93470dbfe4212c020857bccdcb79cb16e2fafda3
Gecko: f107c585cbc0

First broken gaia / Last working gecko - Issue DOES occur
Gaia: 6a391274cd436f8f0d1fad2db8c6b4805703259c
Gecko: 3e839e1fe767

Gaia Pushlog:  https://github.com/mozilla-b2g/gaia/compare/93470dbfe4212c020857bccdcb79cb16e2fafda3...6a391274cd436f8f0d1fad2db8c6b4805703259c

Comment 7

[Jason Smith [:jsmith]]

Broken by bug 881469.

Comment 8

[Oleg Zasypkin [:azasypkin]]

Hey Jayme,

I can't reproduce the issue with the STR provided on both Buri\Hamachi and Flame.

But looking at video provided in the comment 0 I see that the message thread and single outbound message have different timestamps (8.54 for thread and 8.42 for the message) that makes me think that some other manipulations were performed with this broken thread (removed messages, draft and etc.). 

Could you please confirm that initial steps are correct and no other actions required to reproduce it?

Thanks!

Comment 9

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Hi Oleg,
I just verified that the steps in comment 0 do reproduce this issue on the latest 2.0 Flame build.  One thing that might not have been clear from the way that the issue is written is that the message app should be closed with card view after step 2 so that step 3 is opening the app fresh.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140624090250
Gaia: 7476c5b1bfacda9a319f3b4d4e3c37005a0568d1
Gecko: 9e6466bcc0e6
Version: 32.0a2 (2.0) 
Firmware Version: v122

Comment 10

[Oleg Zasypkin [:azasypkin]]

Attachment: GitHub pull request URL

After discussion with Jayme on IRC we found out that the issue occurs with these STR:

1. Open SMS App;
2. Go to the new message composer;
3. Create new message and send it to any recipient (you shouldn't have existent thread for this recipient);
4. You'll be navigated to the panel with the newly created thread;
5. Staying at the same panel close SMS app via card view;
6. Open SMS app once again and observe this thread in the inbox panel.

Actual result:
Preview disappears quickly and thread is marked as draft.

Brogan, I can't distinguish this draft mark on the provided video though. Can you please confirm (or not) that draft without message preview is marked as draft?

Comment 11

[Brogan Zumwalt [Inactive]]

Draft mark appears when issue reproduces in both today's 2.0 Flame build as well as the build the issue was first reported on.

Comment 12

[Oleg Zasypkin [:azasypkin]]

(In reply to Brogan Zumwalt from comment #11)
> Draft mark appears when issue reproduces in both today's 2.0 Flame build as
> well as the build the issue was first reported on.

Nice, thanks! Then we're fixing the right one :)

Comment 13

[Steve Chung [:steveck]]

Comment on attachment 8446407 [details] [review]
GitHub pull request URL

Hi Oleg, I think you patch works well, but your another idea is also significant for reducing the possible regression. I would suggest we take both fixings into the patch, thanks.

Comment 14

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8446407 [details] [review]
GitHub pull request URL

(In reply to Steve Chung [:steveck] from comment #13)
> Comment on attachment 8446407 [details] [review]
> GitHub pull request URL
> 
> Hi Oleg, I think you patch works well, but your another idea is also
> significant for reducing the possible regression. I would suggest we take
> both fixings into the patch, thanks.

Hi Steve, I've updated PR with both solutions.

Thanks!

Comment 15

[Steve Chung [:steveck]]

Comment on attachment 8446407 [details] [review]
GitHub pull request URL

Only one small nit, so r=me. Thanks!

Comment 16

[Oleg Zasypkin [:azasypkin]]

(In reply to Steve Chung [:steveck] from comment #15)
> Comment on attachment 8446407 [details] [review]
> GitHub pull request URL
> 
> Only one small nit, so r=me. Thanks!

Thanks!

Master: https://github.com/mozilla-b2g/gaia/commit/e298a65e00b04a51e6a3cd9bbed036584c3513d0

Comment 17

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/28392b0960667772731131f527c4c74c05d750b1

Comment 18

[Elie]

Attachment: VIDEO0123.mp4

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        3aa0797c111a40e36f722722309668de3d469181
Gecko-Rev       93efc8b4155f0a4a50eaad19acbb95ec24139e63
Build-ID        20141204050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2

This issue has been successfully verified on Flame 2.1:
Gaia-Rev        dbaf3e31c9ba9c3436e074381744f2971e15c7bf
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/ebce587d2194
Build-ID        20141203001205
Version         34.0
Device-Name     flame
FW-Release      4.4.2