1026633 - Add new mobile design kit to resources section

Status: RESOLVED FIXED

(Webmaker Graveyard :: Teaching Kits / Curriculum, defect)

Description

[Matt Thompson (@OpenMatt :OpenMatt)]

* Need to ensure Jess's new kit gets added to the /mobile page

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Kat: let's roadtest a smart way to do this?

* You can submit a pull request here:
https://github.com/mozilla/webmaker.org/blob/master/public/data/content.json

* Ping me to help in IRC as needed

Comment 2

[Kat Braybrooke [:codekat]]

Hey Matt, yes let's talk on IRC. 

Key questions would be what's the max number of kits that can show up (is it 6?) and where we want this to go (in Resources, or a new page?)

Comment 3

[Matt Thompson (@OpenMatt :OpenMatt)]

* cool. yes, should go on one or several /resources pages. (Where do we put stuff for mobile?)

* there's no limit to number of teaching kits. But design-wise is best to limit to three. But we can add more under "more resources" section, too -- we have room for as much content as we like

Comment 4

[Matt Thompson (@OpenMatt :OpenMatt)]

* Kat: can you submit a pull request to add this to the page you think it should be added to?

* + Jess: what competency pages do you think that kit fits?

Comment 5

[Kat Braybrooke [:codekat]]

Cheers will do. Will await Jess's preference for the competenc(ies).

Comment 6

[Kat Braybrooke [:codekat]]

Attachment: Github pull request - content.json

Comment 7

[Kat Braybrooke [:codekat]]

After reflecting on competencies in Jess's absence, I've now added the kit to the Design section via JSON - and have also updated authors and descriptions for the other kits, which were outdated. Asking Kate to review in absence of Aki. (Kate, is this right format for asking?)

Comment 8

[Matt Thompson (@OpenMatt :OpenMatt)]

* Let's see if Ali can take this instead of Kate
* Ali?

Comment 9

[Ali Al Dallal [:alicoding]]

Matt, are you asking me to review this ticket instead of Kate? or what am I assign to do here?

If it's about reviewing Kat patch instead of Kate. All you need to do is change in the "details" section beside the attachment link (https://bugzilla.mozilla.org/attachment.cgi?id=8444868&action=edit) and then change it to my name from there instead.

Comment 10

[Ali Al Dallal [:alicoding]]

Comment on attachment 8444868 [details] [review]
Github pull request - content.json

I suppose it was me to review this based on Matt's comment

Comment 11

[Ali Al Dallal [:alicoding]]

This is also merged

Comment 12

[Matt Thompson (@OpenMatt :OpenMatt)]

* Let's not mark these tickets "resolved" until the requested change is actually live on production.

* Aali: what's the next step? Review on staging?

Comment 13

[Ali Al Dallal [:alicoding]]

The problem here is that this was merged and the other ticket that needs to be push to production included these codes so we didn't have a chance to proof read at least on staging first, so this is now on production.

Kat please close the ticket if the changes on production is fine for this ticket.

Comment 14

[Kat Braybrooke [:codekat]]

I can confirm these are now live on production.