Closed
Bug 1026656
Opened 10 years ago
Closed 10 years ago
nsDNSService::(Async)Resolve accesses temporary variable outside of scope
Categories
(Core :: Networking: DNS, defect)
Core
Networking: DNS
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: erahm, Assigned: badescunicu, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1221196][CID 1221195])
Attachments
(1 file)
1.42 KB,
patch
|
valentin
:
review+
mcmanus
:
review+
|
Details | Diff | Splinter Review |
If |localDomain| is true we take a pointer to a temporary variable[1] and then use it out of scope[2]. [1] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#788 [2] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#793,813,815
Reporter | ||
Comment 1•10 years ago
|
||
Same issue applies to AsyncResolve [1]. [1] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#679,684,701,704
Summary: nsDNSService::Resolve accesses temporary variable outside of scope → nsDNSService::(Async)Resolve accesses temporary variable outside of scope
Whiteboard: [CID 1221196] → [CID 1221196][CID 1221195]
Updated•10 years ago
|
Mentor: valentin.gosu
Assignee | ||
Comment 2•10 years ago
|
||
Attachment #8444167 -
Flags: review?(valentin.gosu)
Comment 3•10 years ago
|
||
Comment on attachment 8444167 [details] [diff] [review] rev1 - fix resolve accessing temporary variable Review of attachment 8444167 [details] [diff] [review]: ----------------------------------------------------------------- Good patch, Nicu! r?ing :mcmanus, as I am not a Necko peer.
Attachment #8444167 -
Flags: review?(valentin.gosu)
Attachment #8444167 -
Flags: review?(mcmanus)
Attachment #8444167 -
Flags: review+
Comment 4•10 years ago
|
||
Comment on attachment 8444167 [details] [diff] [review] rev1 - fix resolve accessing temporary variable Review of attachment 8444167 [details] [diff] [review]: ----------------------------------------------------------------- thanks nicu and valentin
Attachment #8444167 -
Flags: review?(mcmanus) → review+
Assignee | ||
Updated•10 years ago
|
Keywords: checkin-needed
Comment 5•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f8a077acb66 Thanks for the patch, Nicu! One small request, for future patches, please make sure you include a commit message when requesting checkin. Thanks! https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment
Assignee: nobody → badescunicu
Keywords: checkin-needed
Assignee | ||
Comment 6•10 years ago
|
||
Thanks for the tip, Ryan!
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9f8a077acb66
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Updated•6 years ago
|
Blocks: coverity-analysis
You need to log in
before you can comment on or make changes to this bug.
Description
•