1026656 - nsDNSService::(Async)Resolve accesses temporary variable outside of scope

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect)

Description

[Eric Rahm [:erahm]]

If |localDomain| is true we take a pointer to a temporary variable[1] and then use it out of scope[2].

[1] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#788
[2] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#793,813,815

Comment 1

[Eric Rahm [:erahm]]

Same issue applies to AsyncResolve [1].

[1] http://dxr.mozilla.org/mozilla-central/source/netwerk/dns/nsDNSService2.cpp#679,684,701,704

Comment 2

[Nicu Bădescu [:badescunicu]]

Attachment: rev1 - fix resolve accessing temporary variable

Comment 3

[Valentin Gosu [:valentin]]

Comment on attachment 8444167 [details] [diff] [review]
rev1 - fix resolve accessing temporary variable

Review of attachment 8444167 [details] [diff] [review]:
-----------------------------------------------------------------

Good patch, Nicu!
r?ing :mcmanus, as I am not a Necko peer.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8444167 [details] [diff] [review]
rev1 - fix resolve accessing temporary variable

Review of attachment 8444167 [details] [diff] [review]:
-----------------------------------------------------------------

thanks nicu and valentin

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9f8a077acb66

Thanks for the patch, Nicu! One small request, for future patches, please make sure you include a commit message when requesting checkin. Thanks!
https://developer.mozilla.org/en-US/docs/Developer_Guide/Committing_Rules_and_Responsibilities#Checkin_comment

Comment 6

[Nicu Bădescu [:badescunicu]]

Thanks for the tip, Ryan!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9f8a077acb66