Closed
Bug 1026759
Opened 11 years ago
Closed 11 years ago
[GaiaGrid] Re-using grid item objects causes them to not render
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g-v2.0 fixed, b2g-v2.1 fixed)
RESOLVED
FIXED
2.0 S4 (20june)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [p=2],[systemsfe])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
amirn
:
review+
bajaj
:
approval-gaia-v2.0+
|
Details | Review |
It appears we maintain a reference to the current element so we do not render them after a clear(). Let's fix this to allow consumers to re-use item objects if they want.
|
||
Updated•11 years ago
|
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
|
Assignee | |
Comment 1•11 years ago
|
||
Hey guys - I think this should fix the problem. Could you review/land it if it works for you? Thanks!
Attachment #8441691 -
Flags: review?(ran)
Attachment #8441691 -
Flags: review?(amirn)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8441691 [details] [review]
Github pull request
Works great!
Attachment #8441691 -
Flags: review?(ran)
Attachment #8441691 -
Flags: review?(amirn)
Attachment #8441691 -
Flags: review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8441691 [details] [review]
Github pull request
This is needed for the vertical homescreen. We've done our best effort at testing this and believe it is safe for uplift.
Attachment #8441691 -
Flags: approval-gaia-v2.0?(bbajaj)
|
||
Updated•11 years ago
|
Attachment #8441691 -
Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
|
|
Assignee | |
Comment 5•11 years ago
|
||
status-b2g-v2.0:
--- → fixed
status-b2g-v2.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•