If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove the <popupset id="mainpopupset"> element from the blist.xul DOM

RESOLVED FIXED in 1.6

Status

Instantbird
Contacts window
--
trivial
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: florian, Assigned: kapy, Mentored)

Tracking

trunk
x86
Mac OS X

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
See http://mxr.mozilla.org/comm-central/search?string=mainpopupset&find=im%2F

The main <popupset> element has the id mainPopupSet, but some overlays use the value mainpopupset (all lowercase), which causes a new node to be created, instead of merging them.
(Reporter)

Updated

3 years ago
Whiteboard: [mentor=florian]

Updated

3 years ago
Mentor: florian@queze.net
Whiteboard: [mentor=florian]
(Reporter)

Updated

3 years ago
Assignee: nobody → kpsingh201091
(Assignee)

Comment 1

3 years ago
Created attachment 8512113 [details] [diff] [review]
Changed popupset id=mainpopupset element from blist.xul DOM

Check out the patch I have submitted, and let me know if there are any problems in it.

Thanks,
Kapil
Attachment #8512113 - Flags: review?(florian)
(Reporter)

Comment 2

3 years ago
Comment on attachment 8512113 [details] [diff] [review]
Changed popupset id=mainpopupset element from blist.xul DOM

Review of attachment 8512113 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.

Obviously either replacing all the mainPopupSet with mainpopupset, or all the mainpopupset with mainPopupSet would work for Instantbird when using only the built-in overlays, but there may be existing add-ons that correctly used mainPopupSet; so I think in order to not break them we should change the id in the overlays, rather than in the windows.
Attachment #8512113 - Flags: review?(florian) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8512137 [details] [diff] [review]
Bug - 1026784 Changed popupset id=mainpopupset element from blist.xul DOM

Please take a look at this bug.

Thanks,
Kapil
Attachment #8512113 - Attachment is obsolete: true
Attachment #8512137 - Flags: review?(florian)
(Reporter)

Comment 4

3 years ago
Comment on attachment 8512137 [details] [diff] [review]
Bug - 1026784 Changed popupset id=mainpopupset element from blist.xul DOM

Review of attachment 8512137 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! :-)
Attachment #8512137 - Flags: review?(florian) → review+
Keywords: checkin-needed
Thanks for your contribution to Instantbird! Your changes have been committed to comm-central and should be available in the next nightly build of Instantbird (and version 1.6, once it is released).

https://hg.mozilla.org/comm-central/rev/7d0449dffea8
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.6
(Assignee)

Comment 6

3 years ago
Sure, your welcome and thanks for assigning me this bug.
You need to log in before you can comment on or make changes to this bug.