1026784 - Remove the <popupset id="mainpopupset"> element from the blist.xul DOM

Status: RESOLVED FIXED

(Instantbird Graveyard :: Contacts window, defect)

Description

[Florian Quèze [:florian]]

See http://mxr.mozilla.org/comm-central/search?string=mainpopupset&find=im%2F

The main <popupset> element has the id mainPopupSet, but some overlays use the value mainpopupset (all lowercase), which causes a new node to be created, instead of merging them.

Comment 1

[Kapil Singh [:kapy]]

Attachment: Changed popupset id=mainpopupset element from blist.xul DOM

Check out the patch I have submitted, and let me know if there are any problems in it.

Thanks,
Kapil

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8512113 [details] [diff] [review]
Changed popupset id=mainpopupset element from blist.xul DOM

Review of attachment 8512113 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the patch.

Obviously either replacing all the mainPopupSet with mainpopupset, or all the mainpopupset with mainPopupSet would work for Instantbird when using only the built-in overlays, but there may be existing add-ons that correctly used mainPopupSet; so I think in order to not break them we should change the id in the overlays, rather than in the windows.

Comment 3

[Kapil Singh [:kapy]]

Attachment: Bug - 1026784 Changed popupset id=mainpopupset element from blist.xul DOM

Please take a look at this bug.

Thanks,
Kapil

Comment 4

[Florian Quèze [:florian]]

Comment on attachment 8512137 [details] [diff] [review]
Bug - 1026784 Changed popupset id=mainpopupset element from blist.xul DOM

Review of attachment 8512137 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks! :-)

Comment 5

[Patrick Cloke [:clokep]]

Thanks for your contribution to Instantbird! Your changes have been committed to comm-central and should be available in the next nightly build of Instantbird (and version 1.6, once it is released).

https://hg.mozilla.org/comm-central/rev/7d0449dffea8

Comment 6

[Kapil Singh [:kapy]]

Sure, your welcome and thanks for assigning me this bug.