1026788 - Autocomplete issues with backspacing using ai.type keyboard

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Comment 1

[Aaron Train [:aaronmt]]

Regression? Tracking?

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Yeah, regression from the autocomplete rewrite.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Reinsert composition after removing autocomplete text (v1)

Not perfect, but I think this is the best we can do. Ai.type keyboard doesn't notice the finishComposingText call, so we set the composition back after the call.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/fx-team/rev/78517fe42472

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/78517fe42472

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8442194 [details] [diff] [review]
Reinsert composition after removing autocomplete text (v1)

Approval Request Comment

[Feature/regressing bug #]: Bug 994472

[User impact if declined]: Backspacing is badly broken in URL bar when using ai.type keyboard

[Describe test coverage new/current, TBPL]: Locally, m-c

[Risks and why]: Small; the fix has been tested with multiple keyboards, and it only changes the URL bar behavior in limited situations.

[String/UUID change made/needed]: None

Comment 7

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8442194 [details] [diff] [review]
Reinsert composition after removing autocomplete text (v1)

Aurora+

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d98a35628d3c