Closed Bug 1026788 Opened 5 years ago Closed 5 years ago

Autocomplete issues with backspacing using ai.type keyboard

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 33
Tracking Status
firefox30 --- unaffected
firefox31 --- unaffected
firefox32 + fixed
firefox33 --- fixed
fennec 32+ ---

People

(Reporter: jchen, Assigned: jchen)

References

Details

(Keywords: regression)

Attachments

(1 file)

No description provided.
Regression? Tracking?
Yeah, regression from the autocomplete rewrite.
Assignee: nobody → nchen
Blocks: 994472
Status: NEW → ASSIGNED
tracking-fennec: --- → ?
Keywords: regression
Not perfect, but I think this is the best we can do. Ai.type keyboard doesn't notice the finishComposingText call, so we set the composition back after the call.
Attachment #8442194 - Flags: review?(wjohnston)
tracking-fennec: ? → 32+
Attachment #8442194 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/78517fe42472
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 33
Comment on attachment 8442194 [details] [diff] [review]
Reinsert composition after removing autocomplete text (v1)

Approval Request Comment

[Feature/regressing bug #]: Bug 994472

[User impact if declined]: Backspacing is badly broken in URL bar when using ai.type keyboard

[Describe test coverage new/current, TBPL]: Locally, m-c

[Risks and why]: Small; the fix has been tested with multiple keyboards, and it only changes the URL bar behavior in limited situations.

[String/UUID change made/needed]: None
Attachment #8442194 - Flags: approval-mozilla-aurora?
Comment on attachment 8442194 [details] [diff] [review]
Reinsert composition after removing autocomplete text (v1)

Aurora+
Attachment #8442194 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.