Closed Bug 1026828 Opened 6 years ago Closed 6 years ago

Restore MOZ_STORAGE_MEMORY for system jemalloc

Categories

(Toolkit :: Storage, defect)

All
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

Attachments

(1 file)

Attached patch fixSplinter Review
Bug 938730 disabled MOZ_STORAGE_MEMORY for system sqlite. But it didn't take into account MOZ_MEMORY is also defined when system jemalloc is (auto)detected. With system jemalloc there's only one allocator and it's the default one.

For one, FreeBSD 10.0-RELEASE has jemalloc-3.4.0 as the default allocator and which can replace memory/jemalloc.
Attachment #8441779 - Flags: review?(mh+mozilla)
Attachment #8441779 - Flags: review?(mh+mozilla) → review+
Keywords: checkin-needed
The Try run has 2 red builds  with

LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt 

is this related to the patch here ?
(In reply to Carsten Book [:Tomcat] from comment #2)
> The Try run has 2 red builds  with
> 
> LINK : fatal error LNK1123: failure during conversion to COFF: file invalid
> or corrupt 
> 
> is this related to the patch here ?

Sorry, I've wanted to retrigger the jobs but level 1 access doesn't seem to be enough. Those errors were of course unrelated. The patch risk is low: either broken build (typos, #error in mozmemory.h) or regressing bug 938730 (operator precedence).
https://hg.mozilla.org/mozilla-central/rev/d06ae272ade3
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.