1026924 - [Flame][Calendar] Current time indicator should be above event detail ( Day view)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Peko Chen [:pekochen]]

Attachment: week view screenshot.png

Current time indicator should be above event detail ( Week view) and 
should be one pixel thin in week view. (Different with Day view)

Comment 1

[Peko Chen [:pekochen]]

Hi Miller,
Can you please help on this issue?
thank you so much

Peko

Comment 2

[Miller Medeiros [:millermedeiros]]

Hi Peko,

the 2px line is caused because Flame have a higher resolution and it's rounding the height of the line since we use percentage to position the element "top:39.4312%" might be in the middle of 2 pixels. The way to fix this is to use a 1px "border" instead of setting the background-color on the element itself. Borders should not be rounded by Gecko. Another options is to convert the percentage into an absolute pixel value. (border is simpler to implement but unsure if in the future Gecko will change the behavior for higher resolution devices causing a regression).

can you explain better what do you mean with "above event detail"? do you mean that the line should be in between the text and the blue background? - that is not a simple change, in fact it's pretty complex since we would need to split each event into 2 separate elements (one for background color and another just for the text) and the current calendar structure isn't very friendly to this kind of change. Right now we only have the option to put the line behind or on top of the events (background color and text are the same element).

Thanks.

Comment 3

[Miller Medeiros [:millermedeiros]]

I think this should block 2.0 since it's a bug introduced by the visual refresh and happens on Flame. I found a simple way to replicate the day view behavior but I think the "arrow/triangle" should also be on top of the colored border, otherwise it looks weird.

I'm going to provide a patch pretty soon and also some screenshots showing the new behavior.

Comment 4

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20695

did some z-index shuffling, since the event background color has 20% alpha you can still see the line (even tho it's passing behind the events). I believe this should be "good enough" but let me know what you guys think.

PS: notice that now the "arrow" is above the colored border, which I think makes way more sense than previous behavior and is also properly aligned (before it was 1px to the left)

Comment 5

[Miller Medeiros [:millermedeiros]]

Attachment: current_time_patch_1.png

new behavior

Comment 6

[Peko Chen [:pekochen]]

Comment on attachment 8442142 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20695

Hi Miller,

The line looks great now.
Thanks for your help!!

Peko

Comment 7

[Gareth Aye [:gaye] (back from PTO)]

I can't tell the difference between the before and after :(

Comment 8

[Miller Medeiros [:millermedeiros]]

Attachment: before_patch.png

Gareth, the difference is that before the line was on top of the text, now the line is behind it. I also aligned the "arrow" properly (1px to the right) and made sure it is on top of the event (before it was behind the events on day view)

Comment 9

[Dylan Oliver [:doliver]]

triage: bug with 2.0 visual refresh

Comment 10

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8442142 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20695

LGTM!

Comment 11

[Miller Medeiros [:millermedeiros]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/3ba8af193415e274726255ebb286057bd04dd893

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/df7005b7a82a0319afd3dcb87032cf6fb9ba1156

Comment 13

[Edward Chen[:edchen]]

[Environment]
Gaia      43226cf5c3ad19728a88b3786595670b6d60e5c6
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/d0275ba5f438
BuildID   20140701160202
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 14

[Elie]

Attachment: 2014-12-02-16-18-51.png

This issue has been successfully verified on Flame 2.0:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141201000201
Version         32.0
Device-Name     flame
FW-Release      4.4.2


This issue has been successfully verified on Flame 2.1:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141201001201
Version         34.0
Device-Name     flame
FW-Release      4.4.2