1026986 - Cannot build Qt-build due to nsEmbedFunctions.cpp:796:26: error: ‘InstallX11ErrorHandler’ was not declared in this scope

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Qt, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I cannot build Qt-build with following error:

> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp: In function ‘void XRE_InstallX11ErrorHandler()’:
> 14:05.19 /home/toybox/mozilla/src/toolkit/xre/nsEmbedFunctions.cpp:796:26: error: ‘InstallX11ErrorHandler’ was not declared in this scope
> 14:05.19    InstallX11ErrorHandler();
> 14:05.19                           ^

This must be regressed by bug 968196 it added |#if (MOZ_WIDGET_GTK == 2)| to the necessary method for Qt-build.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch

Quick fix.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 8442718 [details] [diff] [review]
Patch

Yeah, that's because we added the GTK2 check here. But I'm not a module owner here, it's Karl.

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 8442718 [details] [diff] [review]
Patch

I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site XRE_InstallX11ErrorHandler()

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Karl Tomlinson (needinfo?:karlt) from comment #3)
> Comment on attachment 8442718 [details] [diff] [review]
> Patch
> 
> I'd prefer MOZ_WIDGET_GTK != 3 for consistency with the call site
> XRE_InstallX11ErrorHandler()

Agreed.

https://hg.mozilla.org/integration/mozilla-inbound/rev/55620c684232

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/55620c684232