Closed Bug 1026990 Opened 10 years ago Closed 10 years ago

[hsb] Duplicated/conflicted shortcut key "Ctrl+Shift+t" in browser window

Categories

(Mozilla Localizations :: hsb / Upper Sorbian, defect)

defect
Not set
normal

Tracking

(firefox31 wontfix, firefox32 fixed, firefox-esr31 wontfix)

RESOLVED FIXED
mozilla32
Tracking Status
firefox31 --- wontfix
firefox32 --- fixed
firefox-esr31 --- wontfix

People

(Reporter: cosmin-malutan, Assigned: milupo)

References

Details

(Whiteboard: [mozmill])

There is a conflict in browser.dtd file for hsb locale: Ctrl+Shift+t it's used both for restoring a closed tab and opening the page source. Access key for restoring a closed tab: http://mxr.mozilla.org/l10n-mozilla-beta/source/hsb/browser/chrome/browser/browser.dtd#59 Access key for opening the page source: http://mxr.mozilla.org/l10n-mozilla-beta/source/hsb/browser/chrome/browser/browser.dtd#82
Are you sure that there is a conflict? In the first case "t" is a commandkey and in the second case it is an accesskey.
Hi Michael! Long time no seen. Great to see that you are still active! In regards this bug you are right, this doesn't look correct. We cannot compare shortcuts and access keys. This may have been overlooked when investigating the issue for bug 1026582.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
It actually toggles the webConsole, and it should restore an closed tab, I assumed is a conflict nut I'm not sure. http://mxr.mozilla.org/l10n-mozilla-beta/source/hsb/browser/chrome/browser/browser.dtd#267 You can download this build: ftp://ftp.mozilla.org/pub/mozilla.org/firefox/releases/31.0b2/linux-x86_64/hsb/firefox-31.0b2.tar.bz2 - open three different tabs - close one - hit Ctrl+Shift+t It should restore the closed tab, instead it opens the console.
keytext is a label only and should not have any relationship here: https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/keytext Lets reopen for further investigation and a better summary.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Summary: [hsb] Duplicated/conflicted shortcut "Ctrl+Shift+t" (both restoring a closed tab and opening page source) → [hsb] Duplicated/conflicted shortcut key "Ctrl+Shift+t" in browser window
Sorry, but I probably treated devToolboxMenuItem.keytext as accesskey. The original keytext key is "l" (lowercase "L", I think, not uppercase "i"). I changed it to "l" on Pootle. I will have a look to Lower Sorbian as well. Thank you for filing the bug.
In the Lower Sorbian browser.dtd it is correct. There I used the original keytext key "l"
Ah, I forgot: On Pootle is already Firefox 3**2** Aurora. I have access to Pootle only. Please change it for 31.0 beta2 on mozilla-central. Thanks.
(In reply to Michael Wolf from comment #7) > Ah, I forgot: On Pootle is already Firefox 3**2** Aurora. I have access to > Pootle only. Please change it for 31.0 beta2 on mozilla-central. Thanks. Francesco, can you help here so we can get it landed on Aurora for testing? If all is fine we also want to have it on beta. Thanks.
Flags: needinfo?(francesco.lodolo)
This locale works on Pootle, so we need to have the localization exported from there (something that I can't do). Apparently we're lucky, since I see a recent export for hsb that change that key http://hg.mozilla.org/releases/l10n/mozilla-aurora/hsb/rev/101b87c4b519
Flags: needinfo?(francesco.lodolo)
Wonderful. Cosmin can you please check that it is working now with the most recent build of the hsb locale?
Assignee: nobody → milupo
Status: REOPENED → ASSIGNED
I asked Axel on the wrong bug 1026582. So applying his feedback here too.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.