1026992 - [FTU] Several issues in navigation_test.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Julien Wajsberg [:julienw]]

While working on bug 874510 I found that a test in navigation_test.js shouldn't pass but it currently does.

So I found there are several main issues:

* the HTML markup is not reset for each test.
* when calling manageStep, a hashchange event will be called even if we don't wait for it to do the next test
* the test "welcome_browser" is wrong because it tests for something that should be in "browser_privacy". It currently passes because of the 2 previous issues.

Comment 1

[Julien Wajsberg [:julienw]]

I have a WIP patch.

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: github PR

Does not fix the second issue yet.

Comment 3

[Julien Wajsberg [:julienw]]

Comment on attachment 8442013 [details] [review]
github PR

Seems to be ready now, but you can wait for Travis before reviewing.
See also bug 874510 for a travis run with the new mocha.

Comment 4

[Fernando Campo (:fcampo)]

Comment on attachment 8442013 [details] [review]
github PR

Just a small nit on github, tried locally and tests pass fine, hopefully Travis will agree soon :)

Comment 5

[Julien Wajsberg [:julienw]]

Fixed the nit and landed in:

master: bd5065ced020014df5fd45259fba1ac32d65673b

Thanks Fernando !

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7938a9ddd4dc