Closed Bug 1027005 Opened 8 years ago Closed 8 years ago

[Collection] Population task triggers

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.0, b2g-v2.0 verified, b2g-v2.1 fixed)

VERIFIED FIXED
2.0 S4 (20june)
feature-b2g 2.0
Tracking Status
b2g-v2.0 --- verified
b2g-v2.1 --- fixed

People

(Reporter: amirn, Assigned: kgrandon)

References

Details

(Whiteboard: [systemsfe])

User Story

The Collection population task should run:
1. for all installed collections - first time a Collection is opened (done: bug 1016241)
2. on app install/uninstall - add/remove app from collections
3. on collection install - run the task for the new collection

Attachments

(2 files)

No description provided.
Depends on: 1016241
Depends on: 1027003
QA Whiteboard: [VH-FL-blocking+][VH-FC-blocking+]
Looks like this is required feature work for collections.

Candice - Can you add the feature-b2g flag here?
Flags: needinfo?(cserran)
feature-b2g: --- → 2.0
Flags: needinfo?(cserran)
User Story: (updated)
Summary: [Collection] Run population task on app install/uninstall → [Collection] Population task triggers
Assignee: nobody → dale
ran / amir / kevin, just a quick pointer asking what a test for this looks like, so it sounds like if I have a smart collection with facebook in it, then install facebook, I should see the icon update? just a simple workflow I can verify with (also pointer to the e.me integration tests would be handy)
Yes, that's correct. If you install facebook, I belive you should see the "Social" collections app icon update.

Also if you remove it, it should update as well. We only have a handful of e.me integration tests in the verticalhome collection_test.js file, working on adding more though.
I'm going to free this bug for now to look at it with Cristian. If we don't make much progress, will assign back to you Dale, or you can steal it in the morning. Thanks.
Assignee: dale → nobody
Cristian - we could really use your help tonight to look into this if you don't have more important things. I think we will need to use IAC perhaps from the homescreen app whenever an app is installed to check if it needs to be part of the 'native info'.

There are two pieces left, app installing/unintalling and collection creation. It would probably help to look at the code here: https://github.com/mozilla-b2g/gaia/pull/20231

I know this is a bit tricky, so if you don't finish a patch or anything, whatever findings you come up with could be useful for us tomorrow. Thanks!
Flags: needinfo?(crdlc)
OK, implementing something
Flags: needinfo?(crdlc)
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee: crdlc → nobody
Status: ASSIGNED → NEW
Depends on: 1028087
I could do the code for app install/uninstall - add/remove app from collections bug 1028087
hope this patch can help, it's something I did real quick and was not tested
Kevin told me that I did it and the bug 1028087 does it

(In reply to Amir Nissim (Everything.me) from comment #8)
> Created attachment 8443391 [details]
> bug_1027005: WIP Population triggers
> 
> hope this patch can help, it's something I did real quick and was not tested
(In reply to Cristian Rodriguez (:crdlc) from comment #9)
> Kevin told me that I did it and the bug 1028087 does it

Sorry Cristian, didn't know about that. I should have checked the bug before I worked on it :(

Anyway, I only handled the collection-app side so you can use my patch for native_info.js and objects.js. It's small and also handles the case collection is removed.

Thanks
Yes it will be very useful for who will do the collection part (collection install). The path is smoother for the last bug here :)

(In reply to Amir Nissim [on PTO until Jul 6] (:amirn) from comment #10)
> (In reply to Cristian Rodriguez (:crdlc) from comment #9)
> > Kevin told me that I did it and the bug 1028087 does it
> 
> Sorry Cristian, didn't know about that. I should have checked the bug before
> I worked on it :(
> 
> Anyway, I only handled the collection-app side so you can use my patch for
> native_info.js and objects.js. It's small and also handles the case
> collection is removed.
> 
> Thanks
Cristian has taken the first part, and the harder one, in the dependent bug. I'm going to take this one to land the more simple install collections part.
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Target Milestone: --- → 2.0 S4 (20june)
Attached file Github pull request
Comment on attachment 8443453 [details] [review]
Github pull request

Dale - this is one of the last FL blockers for 2.0, wondering if you could give it a review. There's two commits in it, but the first one already has an R+.

I'll work on an integration test for this next week.
Attachment #8443453 - Flags: review?(dale)
Yeh I didnt have the background to write this without tests so it was gonna take a while longer, cheers for stealing, taking a look now
Comment on attachment 8443453 [details] [review]
Github pull request

Tested this out, works good for me
Attachment #8443453 - Flags: review?(dale) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/ea40c008305f214c80fccd571284adce8517a4ab
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment on attachment 8443453 [details] [review]
Github pull request

Needed for the vertical homescreen.
Attachment #8443453 - Flags: approval-gaia-v2.0?(bbajaj)
Flags: needinfo?(jlorenzo)
Keywords: verifyme
Attachment #8443453 - Flags: approval-gaia-v2.0?(bbajaj) → approval-gaia-v2.0+
Verified with Social Smart Collection: 
  * Populated when created Smart Collection => OK
  * Populated when installed app from Market Place => NOK. See 1029009
  * Removed when app is unistalled => OK
Status: RESOLVED → VERIFIED
Flags: needinfo?(jlorenzo)
Keywords: verifyme
Whiteboard: [systemsfe]
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.