102701 - Need to revisit String usage after iDNS landing

Status: RESOLVED INCOMPLETE

(Core :: XPCOM, defect, P3)

Description

[Roy Yokoyama]

I see the code segment char* urlStr = url.ToNewCString()
where urlStr may get corrupted if url contains non-ascii DNS. ( see above URL )

Comment 1

[Darin Fisher]

the iDNS checkin did not change anything having to do with the way URLs are
stored.  the URL parts are UTF8, though there are some bugs in which portions
of the URL (in particular the hostname) are treated as ASCII.  so, i suspect
that this bug can be marked INVALID.

Comment 2

[Roy Yokoyama]

darin: thanks for your input.  I'll verify it. 
== assign to myself

Comment 3

[Wil Tan]

Please see a related bug 102656.

Comment 4

[Frank Tang]

P3. Mark as m1.0 

Comment 5

[Wil Tan]

This led me to do some testing.
I loaded http://playground.i-dns.net/mozilla/samples/jpsjis.html and 
dragged one of the URLs onto the desktop to create a shortcut. The location
shown is url-escaped (%XX), which is good. But it is the raw SJIS values.
And since internet shortcuts do not have a charset associated with them, it is 
impossible to recover the UTF8 from it. Maybe we should do something similar 
to bug 102656, i.e. convert the hostname part into UTF8 first before creating
the shortcut?
Okay I realize that this is slightly different from the title of this bug, but 
still related. But this means that if internet shortcuts were created as url
escaped UTF8-hostname then we're fine.
Interestingly, dragging the URL back into Mozilla is fine, because XPIDN does 
the encoding detection.

CC: [e-mail]

Comment 6

[Roy Yokoyama]

I'll wait unitl bug 102656 gets checked in.

Comment 7

[Roy Yokoyama]

moving to 1.0

Comment 8

[Roy Yokoyama]

post 1.0