Remove unused plugin infobar preferences

RESOLVED FIXED in Firefox 33

Status

()

Firefox
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gfritzsche, Assigned: vikneshwar, Mentored)

Tracking

Trunk
Firefox 33
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug] [lang=js])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
We have two unused plugin infobar preferences: plugins.hide_infobar_for_blocked_plugin & plugins.hide_infobar_for_outdated_plugin.

http://hg.mozilla.org/mozilla-central/annotate/37f08ddaea48/browser/app/profile/firefox.js#l649

We should remove them.

Comment 1

4 years ago
yeah, I am interested to do that..
how can I proceed....???
Flags: needinfo?(georg.fritzsche)

Comment 2

4 years ago
Since I was new to this ...Can you help me how to proceed...?
(Reporter)

Comment 3

4 years ago
There is a general developer guide here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide
If you don't have yet, you should check out the source & build Firefox: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions

Comment 0 here describes the lines that need to be removed. Once you have done that, it would be good to confirm that the basic browser tests still run through fine using:
> mach mochitest-browser browser/base/content/test/

Then you should create a patch with your changes that you can submit here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Feel free to contact me via IRC or e-mail if you get stuck.
Flags: needinfo?(georg.fritzsche)
(Assignee)

Comment 4

4 years ago
Created attachment 8443437 [details] [diff] [review]
plugin-pref.patch

Hope this looks good , can you assign me this bug . Thank you :)
Attachment #8443437 - Flags: review?(georg.fritzsche)
(Reporter)

Comment 5

4 years ago
Sure, thanks for the patch!
Assignee: nobody → lviknesh
(Reporter)

Comment 6

4 years ago
Comment on attachment 8443437 [details] [diff] [review]
plugin-pref.patch

This looks fine, thanks. Looking for a peer for an actual r+.
Attachment #8443437 - Flags: review?(georg.fritzsche) → feedback+
(Reporter)

Updated

4 years ago
Status: NEW → ASSIGNED
Attachment #8443437 - Flags: review+

Comment 7

4 years ago
thank you Georg...
(Reporter)

Comment 8

4 years ago
And checked in: https://hg.mozilla.org/integration/fx-team/rev/840334f37ae9
https://hg.mozilla.org/mozilla-central/rev/840334f37ae9
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
You need to log in before you can comment on or make changes to this bug.