1027049 - Remove unused plugin infobar preferences

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Georg Fritzsche [:gfritzsche]]

We have two unused plugin infobar preferences: plugins.hide_infobar_for_blocked_plugin & plugins.hide_infobar_for_outdated_plugin.

http://hg.mozilla.org/mozilla-central/annotate/37f08ddaea48/browser/app/profile/firefox.js#l649

We should remove them.

Comment 1

[sriteja]

yeah, I am interested to do that..
how can I proceed....???

Comment 2

[sriteja]

Since I was new to this ...Can you help me how to proceed...?

Comment 3

[Georg Fritzsche [:gfritzsche]]

There is a general developer guide here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide
If you don't have yet, you should check out the source & build Firefox: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions

Comment 0 here describes the lines that need to be removed. Once you have done that, it would be good to confirm that the basic browser tests still run through fine using:
> mach mochitest-browser browser/base/content/test/

Then you should create a patch with your changes that you can submit here: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch

Feel free to contact me via IRC or e-mail if you get stuck.

Comment 4

[vikneshwar]

Attachment: plugin-pref.patch

Hope this looks good , can you assign me this bug . Thank you :)

Comment 5

[Georg Fritzsche [:gfritzsche]]

Sure, thanks for the patch!

Comment 6

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8443437 [details] [diff] [review]
plugin-pref.patch

This looks fine, thanks. Looking for a peer for an actual r+.

Comment 7

[sriteja]

thank you Georg...

Comment 8

[Georg Fritzsche [:gfritzsche]]

And checked in: https://hg.mozilla.org/integration/fx-team/rev/840334f37ae9

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/840334f37ae9