Closed Bug 1027095 Opened 6 years ago Closed 6 years ago
Result to Web IDL bindings
No description provided.
Comment on attachment 8442408 [details] [diff] [review] Move files and rename class v1 Need a bug number in the commit message. r=me
Attachment #8442408 - Flags: review?(bzbarsky) → review+
Comment on attachment 8442410 [details] [diff] [review] Add WebIDL API and switch to the WebIDL binding v1 >+++ b/content/xul/templates/src/nsXMLBinding.cpp > nsXMLBindingValues::GetNodeAssignmentFor(nsXULTemplateResultXML* aResult, >+ CallQueryInterface(result->GetSingleNodeValue(rv), aNode); GetSingleNodeValue() can return null, no? CallQI is not null-safe. >+++ b/dom/xslt/xpath/txXPathTreeWalker.h >+ return CallQueryInterface(getNode(aNode), aResult); Is that known non-null? r=me modulo that
Attachment #8442410 - Flags: review?(bzbarsky) → review+
(In reply to Boris Zbarsky [:bz] from comment #4) > GetSingleNodeValue() can return null, no? CallQI is not null-safe. Good catch, made a last-minute change and didn't think it through. > Is that known non-null? Should be, yes. We don't allow creating invalid node "wrappers". https://hg.mozilla.org/integration/mozilla-inbound/rev/aa8fd3a1f130 https://hg.mozilla.org/integration/mozilla-inbound/rev/11cb9168a860
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.