1027117 - Remove all uses of innerHTML in localizable content

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::L10n, defect, P4)

Description

[Staś Małolepszy :stas]

When bug 994357 lands we will have a much better and secure alternative to explicitly setting innerHTML on translated elements.  This bug will track the removal of all innerHTML uses in translations.

Comment 1

[Zibi Braniecki [:zbraniecki][:gandalf]]

SMS refactor landed last week, Settings is in review. It leaves System as the last big one to fix.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8652056 [details] [review]
[gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master

We're *that* close to be done with .innerHTML.

Comment 4

[Staś Małolepszy :stas]

Comment on attachment 8652056 [details] [review]
[gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master

This looks great, thanks Zibi.

I wonder if this is the right moment to also fix the JS code which handled those <spans> in translations:  binding events to them, showing and hiding them etc.  We could add a single span to the source HTML and bind to it, since DOM overlays maintain the identity of elements.

What do you think?

Comment 5

[Zibi Braniecki [:zbraniecki][:gandalf]]

Commit: https://github.com/mozilla-b2g/gaia/commit/60b924537fc116e5ff77712985571d70c7b37fb4

Comment 7

[Staś Małolepszy :stas]

This needs to land in l20n.js v2.x.

Comment 8

[Staś Małolepszy :stas]

(In reply to Staś Małolepszy :stas from comment #7)
> This needs to land in l20n.js v2.x.

https://github.com/l20n/l20n.js/commit/1057c621946e96db99ec1fcf4ebeebccf9a97108