46 bytes, text/x-github-pull-request
|Details | Review|
When bug 994357 lands we will have a much better and secure alternative to explicitly setting innerHTML on translated elements. This bug will track the removal of all innerHTML uses in translations.
SMS refactor landed last week, Settings is in review. It leaves System as the last big one to fix.
Comment on attachment 8652056 [details] [review] [gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master We're *that* close to be done with .innerHTML.
Attachment #8652056 - Flags: review?(stas)
Comment on attachment 8652056 [details] [review] [gaia] zbraniecki:1027117-remove-innerHTML-from-l10n > mozilla-b2g:master This looks great, thanks Zibi. I wonder if this is the right moment to also fix the JS code which handled those <spans> in translations: binding events to them, showing and hiding them etc. We could add a single span to the source HTML and bind to it, since DOM overlays maintain the identity of elements. What do you think?
Attachment #8652056 - Flags: review?(stas) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
This needs to land in l20n.js v2.x.
(In reply to Staś Małolepszy :stas from comment #7) > This needs to land in l20n.js v2.x. https://github.com/l20n/l20n.js/commit/1057c621946e96db99ec1fcf4ebeebccf9a97108
You need to log in before you can comment on or make changes to this bug.