1027137 - PageActionLayout cleanup

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: PageActionLayout cleanup

Lots of miscellaneous style/formatting nits.

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8442550 [details] [diff] [review]
PageActionLayout cleanup

Review of attachment 8442550 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/toolbar/PageActionLayout.java
@@ +37,5 @@
>      private static final int DEFAULT_PAGE_ACTIONS_SHOWN = 2;
>  
> +    private final Context mContext;
> +    private final LinearLayout mLayout;
> +    private final ArrayList<PageAction> mPageActionList;

Make this a List.

@@ +134,5 @@
>          });
>      }
>  
>      private void removePageAction(String id) {
> +        for (int i = 0; i < mPageActionList.size(); i++) {

Flip this to an iterator.

@@ +193,5 @@
>  
>      private void refreshPageActionIcons() {
>          final Resources resources = mContext.getResources();
> +        for (int index = 0; index < this.getChildCount(); index++) {
> +            final ImageButton v = (ImageButton) this.getChildAt(index);

And flip this to use i instead of index.

Comment 3

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/5bef1f8045fd

Comment 4

[Carsten Book [:Tomcat]]

sorry had to backout this change in https://tbpl.mozilla.org/?tree=Fx-Team&rev=7e6ee365e01c since the first push caused a test failure like:

https://tbpl.mozilla.org/php/getParsedLog.php?id=43805525&tree=Fx-Team

Comment 5

[Brian Nicholson (:bnicholson)]

Failures were from bug 1027135, which should be fixed.

https://hg.mozilla.org/integration/fx-team/rev/6b76b46afe7a

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6b76b46afe7a