Closed Bug 1027181 Opened 5 years ago Closed 5 years ago

Intermittent browser_946320_tabs_from_other_computers.js | Uncaught exception - Subview (PanelUI-history) did not show within 20 seconds.

Categories

(Firefox :: Toolbars and Customization, defect)

x86_64
macOS
defect
Not set
Points:
8

Tracking

()

RESOLVED FIXED
Firefox 34
Iteration:
34.1
Tracking Status
firefox32 --- unaffected
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- unaffected

People

(Reporter: RyanVM, Assigned: smacleod)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=41962450&tree=Mozilla-Central

Rev5 MacOSX Mountain Lion 10.8 mozilla-central debug test mochitest-browser-chrome-1 on 2014-06-18 06:31:38 PDT for push 66b1c8b74e66
slave: talos-mtnlion-r5-020

06:48:08  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_946320_tabs_from_other_computers.js | Uncaught exception - Subview (PanelUI-history) did not show within 20 seconds.
06:48:08     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_946320_tabs_from_other_computers.js | Leaving test
06:48:08     INFO -  TEST-INFO | MEMORY STAT vsize after test: 3899396096
06:48:08     INFO -  TEST-INFO | MEMORY STAT residentFast after test: 775036928
06:48:08     INFO -  TEST-INFO | MEMORY STAT heapAllocated after test: 131738952
06:48:08     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/components/customizableui/test/browser_946320_tabs_from_other_computers.js | finished in 20753ms
Gavin, I see that Gijs is on PTO for awhile. Can you recommend somebody else to look at this? It's a top orange and I'm looking at disabling it otherwise.
Flags: needinfo?(gavin.sharp)
Steven, any chance you could take a look?
Flags: needinfo?(gavin.sharp) → needinfo?(smacleod)
Sure I'll give it a shot.

Marco, please add this to the current iteration.
Assignee: nobody → smacleod
Status: NEW → ASSIGNED
Iteration: --- → 34.1
Points: --- → 8
Flags: needinfo?(smacleod) → needinfo?(mmucci)
Added to Iteration 34.1
QA Whiteboard: [qa?]
Flags: needinfo?(mmucci)
QA Whiteboard: [qa?] → [qa-]
Flags: firefox-backlog+
Attached patch b1027181.patchSplinter Review
I think EventUtils.synthesizeMouseAtCenter is at fault here. It appears that the history button gets focused but not clicked when the test fails (was able to reproduce locally once).

I suspect the mousedown/mouseup events aren't being sent reliably here [1]

The synthesized mouse events also seemed to be a problem in Bug 993712. I'll file a bug regarding the reliability of synthesizeMouse*.

In this patch I just call click() instead of synthesizing a mouse event.


[1] http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/tests/SimpleTest/EventUtils.js?rev=ab6ad70d1a3e#268
Attachment #8466427 - Flags: review?(mconley)
Comment on attachment 8466427 [details] [diff] [review]
b1027181.patch

Review of attachment 8466427 [details] [diff] [review]:
-----------------------------------------------------------------

Yeah, let's give this a shot. If this clears the orange, then yeah - we've got problems with synthesizeMouseAtCenter that we've gotta figure out.
Attachment #8466427 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/802fafabb72b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.