1027250 - [Rocketbar] Search suggestions in the Homescreen settings isn't consistent with the rest of the UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, enhancement)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: screenshot

1. go to settings -> homescreen
2. take a look at the Search Suggestions

Expected: the left justifications isn't quite consistent with the rest of the UI.
( ie see Settings -> internet Sharing where it would display the current settings and then have a button for going to the search suggestion panel.  The other option is to have a toggle to enable / disable search suggestions. See Settings -> Navigation )
Actual : it's left justified, w/ enabled/disabled right below and a > to go to the next panel

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-06-18-12-31-41.png

internet sharing.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: 2014-06-18-12-31-53.png

Navigation

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Marking as enhancement because this is against the design and not functional change.
It's my own opinion that it's not consistent, so I understand if it's marked as won't fix.

Asking for fxos ux input.

Comment 4

[Stephany Wilkes]

Flagging Francis to advise.

Comment 5

[Francis Djabri [:djabber]]

I agree with you, Naoki. The setting should follow general patterns. The text for the Search suggestions should be aligned with the other text in the view. It may not be shown this way in the wireframes but the wireframes should not be taken as a specification of the visual layout. Eric, is there a visual spec for the Homescreen settings that can be referred to?

Comment 6

[Eric Pang [:epang] UX]

Attachment: Homescreen Settings.jpg

Hi,

I've added an image that should use the building blocks.  I followed what is used in internet sharing since it looks visually cleaner.  This also removes the need for a second page.  I believe there are future plans to align all the building blocks since there are many inconsistencies.

Comment 7

[Eric Pang [:epang] UX]

Also wanted to note that there's a faint grey box that shows up surrounding the text/drop downs that should be there.

Comment 8

[Francis Djabri [:djabber]]

This looks great, thanks Eric

Comment 9

[Cristian Rodriguez (:crdlc)]

Attachment: Implementation

Is it ok? Thanks

Comment 10

[Cristian Rodriguez (:crdlc)]

Attachment: Github pull request

Thanks for your time mate

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Djabri,

this is the spec (with your name on it) I got from another bug : https://bug1027253.bugzilla.mozilla.org/attachment.cgi?id=8442305

If we are going to change the style, can you update the spec and upload it here ? (Or where can I get the latest one ?)

Comment 12

[Cristian Rodriguez (:crdlc)]

I've implemented comment 6

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Yes I know, thanks for your works, Rodriguez.

But I still need the spec to be updated.

Comment 14

[Cristian Rodriguez (:crdlc)]

So ni to him

Comment 15

[Eric Pang [:epang] UX]

Comment on attachment 8452897 [details]
Implementation

This looks good to me, thanks Cristian!

Comment 16

[Cristian Rodriguez (:crdlc)]

You're welcome

(In reply to Eric Pang [:epang] from comment #15)
> Comment on attachment 8452897 [details]
> Implementation
> 
> This looks good to me, thanks Cristian!

Comment 17

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8452900 [details]
Github pull request

Rodriguez, thanks your works.

I left some comments on Github and please take a look, thanks !

Comment 18

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8452900 [details]
Github pull request

addressed, thanks

Comment 19

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Comment on attachment 8452900 [details]
Github pull request

Thanks !

Comment 20

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Please land after your get the green light by the way.

Comment 21

[Cristian Rodriguez (:crdlc)]

Merged in master:

https://github.com/crdlc/gaia/commit/361adcfb00e79be20c69add7d1803767920b3a36

Comment 22

[Francis Djabri [:djabber]]

Spec has been updated at https://mozilla.box.com/s/4pfp6y8pjhwojtt9yhl8