Closed Bug 1027250 Opened 5 years ago Closed 5 years ago

[Rocketbar] Search suggestions in the Homescreen settings isn't consistent with the rest of the UI

Categories

(Firefox OS Graveyard :: Gaia::Settings, enhancement)

ARM
Gonk (Firefox OS)
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S6 (18july)

People

(Reporter: nhirata, Assigned: crdlc)

References

Details

(Whiteboard: [systemsfe])

Attachments

(6 files)

Attached image screenshot
1. go to settings -> homescreen
2. take a look at the Search Suggestions

Expected: the left justifications isn't quite consistent with the rest of the UI.
( ie see Settings -> internet Sharing where it would display the current settings and then have a button for going to the search suggestion panel.  The other option is to have a toggle to enable / disable search suggestions. See Settings -> Navigation )
Actual : it's left justified, w/ enabled/disabled right below and a > to go to the next panel
Marking as enhancement because this is against the design and not functional change.
It's my own opinion that it's not consistent, so I understand if it's marked as won't fix.

Asking for fxos ux input.
Severity: normal → enhancement
Flags: needinfo?(firefoxos-ux-bugzilla)
Flagging Francis to advise.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(fdjabri)
I agree with you, Naoki. The setting should follow general patterns. The text for the Search suggestions should be aligned with the other text in the view. It may not be shown this way in the wireframes but the wireframes should not be taken as a specification of the visual layout. Eric, is there a visual spec for the Homescreen settings that can be referred to?
Flags: needinfo?(fdjabri) → needinfo?(epang)
Attached image Homescreen Settings.jpg
Hi,

I've added an image that should use the building blocks.  I followed what is used in internet sharing since it looks visually cleaner.  This also removes the need for a second page.  I believe there are future plans to align all the building blocks since there are many inconsistencies.
Flags: needinfo?(epang)
Also wanted to note that there's a faint grey box that shows up surrounding the text/drop downs that should be there.
This looks great, thanks Eric
QA Whiteboard: [VH-FL-blocking-][VH-FC-blocking-]
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Attached image Implementation
Is it ok? Thanks
Attachment #8452897 - Flags: ui-review?(epang)
Attached file Github pull request
Thanks for your time mate
Attachment #8452900 - Flags: review?(ejchen)
Djabri,

this is the spec (with your name on it) I got from another bug : https://bug1027253.bugzilla.mozilla.org/attachment.cgi?id=8442305

If we are going to change the style, can you update the spec and upload it here ? (Or where can I get the latest one ?)
I've implemented comment 6
Yes I know, thanks for your works, Rodriguez.

But I still need the spec to be updated.
So ni to him
Flags: needinfo?(fdjabri)
Comment on attachment 8452897 [details]
Implementation

This looks good to me, thanks Cristian!
Attachment #8452897 - Flags: ui-review?(epang) → ui-review+
You're welcome

(In reply to Eric Pang [:epang] from comment #15)
> Comment on attachment 8452897 [details]
> Implementation
> 
> This looks good to me, thanks Cristian!
Whiteboard: [systemsfe]
Comment on attachment 8452900 [details]
Github pull request

Rodriguez, thanks your works.

I left some comments on Github and please take a look, thanks !
Attachment #8452900 - Flags: review?(ejchen)
Comment on attachment 8452900 [details]
Github pull request

addressed, thanks
Attachment #8452900 - Flags: review?(ejchen)
Comment on attachment 8452900 [details]
Github pull request

Thanks !
Attachment #8452900 - Flags: review?(ejchen) → review+
Please land after your get the green light by the way.
Merged in master:

https://github.com/crdlc/gaia/commit/361adcfb00e79be20c69add7d1803767920b3a36
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
Spec has been updated at https://mozilla.box.com/s/4pfp6y8pjhwojtt9yhl8
Flags: needinfo?(fdjabri)
You need to log in before you can comment on or make changes to this bug.