Closed Bug 1027263 Opened 7 years ago Closed 7 years ago

Extract GeckoInputDispatcher Into It's own File

Categories

(Core Graveyard :: Widget: Gonk, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mchang, Assigned: mchang)

References

Details

(Keywords: perf, Whiteboard: [c=cleanup p=2 s=2014.06.20 u=])

Attachments

(1 file)

Right now the Gecko Input Dispatcher code is stuck in gonk/nsAppShell.cpp. Since we want to do interpolation and resampling, we should move it out into it's own file.
Blocks: input-thread
Whiteboard: [c=cleanup p=3 s= u=] → [c=cleanup p=2 s= u=]
Attached patch bug1027263.patchSplinter Review
Hey Kats, if you could please review this. Just extracted out the GeckoInputDispatcher code into its own file. Didn't change any of the logic. Thanks!

And the try build for now looking good for now: https://tbpl.mozilla.org/?tree=Try&rev=b67dff596762.
Attachment #8442516 - Flags: review?(bugmail.mozilla)
I don't see the value in doing this. nsAppShell basically only holds input handling code along with some basic hook ups for nsAppShell.
Comment on attachment 8442516 [details] [diff] [review]
bug1027263.patch

Review of attachment 8442516 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is worth doing, as eventually there's going to be a touch event interpolator in here somewhere as well (although we'll probably want to reuse that bit across platforms). However I'm not a peer for gonk widget code, so redirecting review to mwu.
Attachment #8442516 - Flags: review?(bugmail.mozilla) → review?(mwu)
After talking with :mwu, he suggested we create a different file, GeckoTouchDispatcher and do the touch interpolation + vsync dispatch there. He thinks its cleaner to keep nsAppShell the center of all input events, which I concur with. So the architecture is:

nsAppShell::GeckoInputDispatcher > GeckoTouchDispatcher.cpp. In GeckoTouchDispatcher.cpp, we interpolate the events. This might also be useful if we port it to other platforms. Because of this change, this bug is resolved.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Whiteboard: [c=cleanup p=2 s= u=] → [c=cleanup p=2 s=2014.06.20 u=]
Attachment #8442516 - Flags: review?(mwu)
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.