Extract GeckoInputDispatcher Into It's own File

RESOLVED WONTFIX

Status

()

Core
Widget: Gonk
P1
normal
RESOLVED WONTFIX
3 years ago
3 years ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

({perf})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c=cleanup p=2 s=2014.06.20 u=])

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Right now the Gecko Input Dispatcher code is stuck in gonk/nsAppShell.cpp. Since we want to do interpolation and resampling, we should move it out into it's own file.
(Assignee)

Updated

3 years ago
Blocks: 930939
(Assignee)

Updated

3 years ago
Whiteboard: [c=cleanup p=3 s= u=] → [c=cleanup p=2 s= u=]
(Assignee)

Comment 1

3 years ago
Created attachment 8442516 [details] [diff] [review]
bug1027263.patch

Hey Kats, if you could please review this. Just extracted out the GeckoInputDispatcher code into its own file. Didn't change any of the logic. Thanks!

And the try build for now looking good for now: https://tbpl.mozilla.org/?tree=Try&rev=b67dff596762.
Attachment #8442516 - Flags: review?(bugmail.mozilla)

Comment 2

3 years ago
I don't see the value in doing this. nsAppShell basically only holds input handling code along with some basic hook ups for nsAppShell.
Comment on attachment 8442516 [details] [diff] [review]
bug1027263.patch

Review of attachment 8442516 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is worth doing, as eventually there's going to be a touch event interpolator in here somewhere as well (although we'll probably want to reuse that bit across platforms). However I'm not a peer for gonk widget code, so redirecting review to mwu.
Attachment #8442516 - Flags: review?(bugmail.mozilla) → review?(mwu)
(Assignee)

Comment 4

3 years ago
After talking with :mwu, he suggested we create a different file, GeckoTouchDispatcher and do the touch interpolation + vsync dispatch there. He thinks its cleaner to keep nsAppShell the center of all input events, which I concur with. So the architecture is:

nsAppShell::GeckoInputDispatcher > GeckoTouchDispatcher.cpp. In GeckoTouchDispatcher.cpp, we interpolate the events. This might also be useful if we port it to other platforms. Because of this change, this bug is resolved.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Whiteboard: [c=cleanup p=2 s= u=] → [c=cleanup p=2 s=2014.06.20 u=]

Updated

3 years ago
Attachment #8442516 - Flags: review?(mwu)
You need to log in before you can comment on or make changes to this bug.