1027300 - UMR in stun_get_siocgifconf_addrs

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Byron Campen [:bwc]]

If any failure occurs here:

http://dxr.mozilla.org/mozilla-central/source/media/mtransport/third_party/nICEr/src/stun/addrs.c?from=stun_get_siocgifconf_addrs&case=true#608

|ptr| will be left pointing at uninitialized memory. A failure in the socket call above would do this, for sure.

Comment 1

[Eric Rescorla (:ekr)]

Note that this needs to be fixed concurrently in the nICEr repo.

Comment 2

[Byron Campen [:bwc]]

Attachment: Check for ioctl error return.

Comment 3

[Byron Campen [:bwc]]

Comment on attachment 8481567 [details] [diff] [review]
Check for ioctl error return.

Review of attachment 8481567 [details] [diff] [review]:
-----------------------------------------------------------------

https://tbpl.mozilla.org/?tree=Try&rev=002920234613

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Before checkin, note comment 1 from ekr about upstream

Comment 5

[Byron Campen [:bwc]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c220f15e006b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c220f15e006b

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Randell Jesup [:jesup] from comment #4)
> Before checkin, note comment 1 from ekr about upstream

byron: has this been checked-in upstream?

Comment 8

[Byron Campen [:bwc]]

Yes.