1027337 - Replace PIL with Pillow

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task, P3)

Description

[Michael Cooper [:mythmon]]

+++ This bug was initially created as a clone of Bug #915742 +++

PIL, the Python Image Library, hasn't been updated for 4 years or so. The latest version is not even on Pypi.

Pillow [https://pypi.python.org/pypi/Pillow/2.1.0] is backwards-compatible with PIL and actively maintained. We should try to switch. It might require a few tweaks, which is why I think it deserves its own bug.

Comment 1

[Michael Cooper [:mythmon]]

The comments above were all from the cloned bug. I don't expect this to be hard. This makes things like Vagrant and Travis and setup stuff easier, and I'm already running Pillow locally. I suspect :willkg is too.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Just to clarify something, Pillow is not backwards-compatible with PIL in regards to bug-fixes. I talked with one of the Pillow devs at PyCon and he said that while they are mostly API backwards-compatible, they have fixed a bunch of bugs which if we were depending on them, would work differently in Pillow.

I've been using Pillow since I started, so I think it's safe, but we should keep in mind that this is a difference between our development environments and production. It'd be nice to account for that somehow. Either by updating production so we're using Pillow across the board or by making sure our unit test system has good coverage of the PIL/Pillow-using code and uses the version of PIL we use in production.

Comment 3

[Dean Johnson [:deanj]]

https://github.com/mozilla/kitsune/pull/1984 for reference to rehandalal's PR.

Comment 4

[Dean Johnson [:deanj]]

https://github.com/mozilla/kitsune/pull/2083 changed in PR for switch from /vendor to peep package management.

Comment 5

[Dean Johnson [:deanj]]

Merged with commit: e1712e0ba606747a00b3beb81fbea6f52408dad7.