1027349 - [Calendar] month view week day names should be a single char

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Miller Medeiros [:millermedeiros]]

day names on the month view are supposed to be a single char and right now they use the `'weekday-' + day + '-short'` format (which is 3 chars in English)

this will probably require a new locale string which means we need to fix it by Friday if we want it to be shipped on 2.0 otherwise we will have to wait till 2.1 (late-l10n)

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: month_day_names.png

Peko, do you agree that this should be fixed? was looking at the specs and our integration tests and saw that it was wrong.. Probably introduced by the new L10n code since we did not change anything on the view/template.

Comment 2

[Miller Medeiros [:millermedeiros]]

I think this only happens after locale change!!

steps to reproduce:

 1. open calendar app
 2. go to month view (everything is fine)
 3. go to settings app and change language to something else besides english
 4. go back to calendar app
 5. open month view (see that there are 3 chars on header)
 6. go to settings and change language again to english
 7. go back to calendar app month view (3 chars on the header)

Device: Flame
Build Id: 20140611091240
Gecko: 33.0a1
Gaia: 0750f66a

Comment 3

[Peko Chen [:pekochen]]

Hi Miller,

based on our spec, the week day on month view should be single character.
I think it should be fixed.
thanks!

Comment 4

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20766

created a different locale key instead of slicing the first char since I believe the slice wouldn't work well with all languages and would need custom JS logic to update the values every time the locale changed.

Comment 5

[Francesco Lodolo [:flod]]

Comment on attachment 8443039 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/20766

Left a small nit about the comment but yes, definitely safer like this.

P.S. I'm not sure, but if you need this on 2.0, it needs to be marked as late-l10n and technically land before the end of the day

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> P.S. I'm not sure, but if you need this on 2.0, it needs to be marked as
> late-l10n and technically land before the end of the day

Not enough coffee in the system, missed the keyword already there, staring at me.

Comment 7

[Miller Medeiros [:millermedeiros]]

I updated the comment, thanks Francesco!

landed on master: https://github.com/mozilla-b2g/gaia/commit/734d8459bd65ab31ac9d878817a5cc73a7251fc1

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      b3324d031fe91b864090461ffcacc6ca605a2903
Gecko     https://hg.mozilla.org/mozilla-central/rev/afa67a2f7905
BuildID   20140629160201
Version   33.0a1
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014

[Result]
Pass