Closed Bug 1027365 Opened 10 years ago Closed 10 years ago

Activate ImageBridge by default when OMTC on.

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: nical, Assigned: nical)

References

Details

Attachments

(2 files, 1 obsolete file)

      No description provided.
Attached patch patch (obsolete) — Splinter Review
I am not sure this actually changes anything (by the look of it async-video was already preffed on everywhere) but it makes it more explicit and simpler.
Assignee: nobody → nical.bugzilla
Attachment #8442452 - Flags: review?(sotaro.ikeda.g)
To get async-video on windows+e10s we need to fix the issue that caused us to disable it in 1009616.
Attachment #8442452 - Attachment is obsolete: true
Attachment #8442452 - Flags: review?(sotaro.ikeda.g)
Attachment #8442465 - Flags: review?(sotaro.ikeda.g)
Blocks: 1027073
Attachment #8442465 - Flags: review?(sotaro.ikeda.g) → review+
(In reply to Nicolas Silva [:nical] from comment #2)
> Created attachment 8442465 [details] [diff] [review]
> v2 - Always use ImageBridge except with e10s on windows
> 
> To get async-video on windows+e10s we need to fix the issue that caused us
> to disable it in 1009616.

sorry for the dumb question, bug now that bug 1009616 is fixed, should anything happen here?
(In reply to Marco Bonardo [::mak] (needinfo? me) from comment #5)
> sorry for the dumb question, bug now that bug 1009616 is fixed, should
> anything happen here?

Bug 1009616, made it possible to disable async-video with e10s while keeping it enabled with OMTC when e10s is not enabled. What needs to happen here is enable async-video regardless of whether e10s is enabled on windows (on all of the other platforms async-video is always enabled regardless of e10s).
ok, sorry I asked just cause E10s keeps hanging for me on pages with html5 videos, setting layers.async-video-oop.enabled to true seems to solve the problem.
Here's a try push with async-video enabled by default everywhere. What caused us to disable it was an intermittent shutdown timeout and things have improved in the area of OMTC shutdown so it's worth looking if the problem still exist.

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=9454a3a396ec
With this patch, async-video will be on by default on windows+e10s (this is the only platforms where it wasn't already activated by default).
Attachment #8506877 - Flags: review?(jmuizelaar)
Attachment #8506877 - Flags: review?(jmuizelaar) → review+
Blocks: 1065470
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [leave-open]
You need to log in before you can comment on or make changes to this bug.