1027380 - Paint flashing from an inactive layer manager saturates the transparent layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Benoit Girard (:BenWa)]

Attachment: patch

Using paint flashing in some cases where I have a transparent layer that uses an inactive layer manager to draw sometimes yields an overly saturated paint-flash color making the background even more difficult to solve. We shouldn't paint-flash inactive layer manager because the active layer manager will flash it.

Comment 1

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d4bf4c76854e

Comment 2

[Benoit Girard (:BenWa)]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f57cf85fd128

Didn't know we had tests for this. Nice :D

Comment 3

[Benoit Girard (:BenWa)]

CC'ing mstange since matt thinks you might of tried to land something like this before.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch

This gives us paint flashing for offscreen rendering, which the failing test require.

Or maybe we should just remove that test. Up to you.

Comment 5

[Markus Stange [:mstange]]

Your patch looks much better than mine in bug 1009680 and it won't cause the test failure that I encountered.

Comment 6

[Markus Stange [:mstange]]

Oh, I see now that that was exactly the intention.

Comment 7

[Benoit Girard (:BenWa)]

Right, we both had the same v1.

Comment 8

[Markus Stange [:mstange]]

-  if (presContext->GetPaintFlashing()) {
+  if (presContext->GetPaintFlashing() &&
+    !aLayer->Manager()->IsInactiveLayerManager()) {
     ^^ wrong indent

(In reply to Benoit Girard (:BenWa) (Off until June 30th) from comment #4)
> Or maybe we should just remove that test. Up to you.

We could also create a reftest instead. For example we could copy layout/reftests/reftest-sanity/invalidation.html and use it with

pref(nglayout.debug.paint_flashing,true) != invalidation.html about:blank

Since reftests should always be using widget layers, this should work with the v1 patch. We can also make it conditional on layersGPUAccelerated if it doesn't.

Comment 10

[Benoit Girard (:BenWa)]

Opps. I though I had landed that.

Yes we could create a new better test for it. We need to be careful how we compare because if we only paint flash for thebes layer and about:blank can use a color layer.

Comment 11

[Benoit Girard (:BenWa)]

Attachment: patch rebased

Comment 12

[Benoit Girard (:BenWa)]

ttps://hg.mozilla.org/integration/mozilla-inbound/rev/24b61c6aad57

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/24b61c6aad57