1027381 - [SCR][Rocketbar] Can we do a reduction of flashing via a comparison with this found set versus last found set?

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, enhancement)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. tap Rocketbar
2. type t
3. type e
4. type s
5. type t

Expected: It wouldn't refresh so much after each type because it does a compare/diff from the last found set

Actual: refreshes each time there's a letter change

Gaia      83844c7679b3b9f6e7f1116c1eeec2d1e7a64eec
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/55679dc2e72b
BuildID   20140618000202
Version   32.0a2
ro.build.version.incremental=108
ro.build.date=Tue Jun 10 19:40:40 CST 2014
flame

Marking as an enhancement

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

To go with the previous perf issue.

Comment 2

[Kevin Grandon :kgrandon]

I would assume that we should be able to leverage platform caching here. We should do an investigation to see why we currently wouldn't be leveraging that. Keeping a manual cache in javascript seems to be asking for problems, but maybe we can investigate it.

Comment 3

[Mike Lee [:mlee]]

Removing perf keyword as the flashing described is a functional issue with Rocketbar's implementation and not a performance issue.

Comment 4

[Ben Francis [:benfrancis]]

(In reply to Kevin Grandon :kgrandon from comment #2)
> I would assume that we should be able to leverage platform caching here. We
> should do an investigation to see why we currently wouldn't be leveraging
> that. Keeping a manual cache in javascript seems to be asking for problems,
> but maybe we can investigate it.

In the browser app we kept a cache of icons in IndexedDB and a "result cache" in memory as you type. It actually worked quite well.

I think the challenges for the search app are a bit different because most of the results currently come remotely from EverythingMe and Firefox Marketplace rather than from local browsing history, but I don't think relying on the platform's browser cache is working too well here.

We need to do something smarter because this is currently painful to use, especially on a Flame configured for 319MB. Part of the solution might be a different UI, which UX are currently exploring.

Comment 5

[Dale Harvey (:daleharvey)]

Refreshing is not an issue with the current one line implementation