Stk Timer Expiration Envelope Command requires timer value

RESOLVED FIXED in Firefox OS v2.1

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: sbarton, Assigned: frsela)

Tracking

unspecified
2.1 S3 (29aug)
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:2.1+, b2g-v2.1 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Timer Expiration Envelope Command requires a timer value. Currently only a timerId is included in the Timer Expiration message.

Timer value is included in the Timer Expiration Envelope Command as specified in 3GPP TS 11.14 section 10.2 "Structure of ENVELOPE (TIMER EXPIRATION)": 

"Timer value: difference between the time when this command is issued and the time when the timer was initially started. This should be as close as possible to the value of the timer given in the initial TIMER MANAGEMENT command."

https://github.com/mozilla-b2g/gaia/blob/9141d16e1881eda5192b7b1dc6a7174d2b0a8613/apps/system/js/icc_worker.js#L445
(Reporter)

Updated

4 years ago
blocking-b2g: --- → 2.1?
Flags: needinfo?(frsela)
(Reporter)

Updated

4 years ago
Component: Gaia::System → Gaia::Settings
You mean add the TimerValue into the sendStkTimerExpiration call?
The same one used bellow here: https://github.com/mozilla-b2g/gaia/blob/9141d16e1881eda5192b7b1dc6a7174d2b0a8613/apps/system/js/icc_worker.js#L454 ?
Flags: needinfo?(frsela) → needinfo?(sbarton)
(Reporter)

Comment 2

4 years ago
Yes add that timerValue into the sendStkTimerExpiration call.
Flags: needinfo?(sbarton)

Updated

4 years ago
Blocks: 1025317

Comment 3

4 years ago
Hi Spencer, could you provide the user impact here? Thanks.
Flags: needinfo?(sbarton)
(Reporter)

Comment 4

4 years ago
Howie: This bug fix is necessary to meet specifications (3GPP TS 11.14). The SIM Timer Expiration Envelope Command has been implemented but remains buggy. - Spencer
Flags: needinfo?(sbarton)

Comment 5

4 years ago
Hi Fernando, could you help with this? thank you
Status: UNCONFIRMED → NEW
blocking-b2g: 2.1? → 2.1+
Ever confirmed: true
Flags: needinfo?(frsela)
Assignee: nobody → frsela
Flags: needinfo?(frsela)
Created attachment 8472896 [details] [review]
Inform the real used time to the SIM Card

@Spencer, The proposed patch sends the real needed time in seconds. Is it needed in ms?
Attachment #8472896 - Flags: review?(ehung)
Attachment #8472896 - Flags: feedback?(sbarton)

Comment 7

4 years ago
Comment on attachment 8472896 [details] [review]
Inform the real used time to the SIM Card

Hi Fernanado, yes, sending the time in seconds is perfect!

Just verified this patch and it's working as expected.
Attachment #8472896 - Flags: feedback?(sbarton) → feedback+

Comment 8

4 years ago
Comment on attachment 8472896 [details] [review]
Inform the real used time to the SIM Card

Looks good to me.
Attachment #8472896 - Flags: review?(ehung) → review+
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-b2g-v2.1: --- → fixed
Target Milestone: --- → 2.1 S3 (29aug)
You need to log in before you can comment on or make changes to this bug.