Create a Vagrantfile for Ship It

RESOLVED FIXED

Status

Release Engineering
Release Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: zeller, Assigned: zeller)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

3 years ago
Create a Vagrantfile for the Ship It app found here http://git.mozilla.org/?p=build/release-kickoff.git
(Assignee)

Updated

3 years ago
Assignee: nobody → johnlzeller
(Assignee)

Comment 1

3 years ago
Created attachment 8443103 [details] [diff] [review]
bug1027435.patch

This patch adds a Vagrantfile and shell script to the base of the release-kickoff (ship it app) repo.
Attachment #8443103 - Flags: review?
(Assignee)

Comment 2

3 years ago
Created attachment 8443129 [details] [diff] [review]
bug1027435.patch

Rolled the previous patch of two files into the same one file.
Attachment #8443103 - Attachment is obsolete: true
Attachment #8443103 - Flags: review?
Attachment #8443129 - Flags: review?
Comment on attachment 8443129 [details] [diff] [review]
bug1027435.patch

Review of attachment 8443129 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed

::: .gitignore
@@ +28,4 @@
>  
>  *.db
>  *.log
> +.vagrant/
\ No newline at end of file

missing newline

::: Vagrantfile
@@ +1,2 @@
> +Vagrant.configure("2") do |config|
> +  config.vm.box = "hashicorp/precise64"

Worth a comment that this is "just a basic box", so no one has to worry later if they switch it out.
Attachment #8443129 - Flags: review? → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8443135 [details] [diff] [review]
bug1027435.patch

Using global variable in ruby instead, added extra line to .gitignore and comment about vagrant box
Attachment #8443129 - Attachment is obsolete: true
Attachment #8443135 - Flags: review?
(Assignee)

Comment 5

3 years ago
Created attachment 8443163 [details] [diff] [review]
bug1027435.patch

Added comments to README
Attachment #8443135 - Attachment is obsolete: true
Attachment #8443135 - Flags: review?
(Assignee)

Comment 6

3 years ago
It's working well! Pull the repo, cd into it, run vagrant up and visit http://127.0.0.1:5000/ to see it work!
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Great, thanks John, I tried it this morning and it worked fine.
You need to log in before you can comment on or make changes to this bug.