Closed Bug 1027435 Opened 6 years ago Closed 6 years ago

Create a Vagrantfile for Ship It

Categories

(Release Engineering :: Release Automation: Other, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: zeller, Assigned: zeller)

Details

Attachments

(1 file, 3 obsolete files)

Create a Vagrantfile for the Ship It app found here http://git.mozilla.org/?p=build/release-kickoff.git
Assignee: nobody → johnlzeller
Attached patch bug1027435.patch (obsolete) — Splinter Review
This patch adds a Vagrantfile and shell script to the base of the release-kickoff (ship it app) repo.
Attachment #8443103 - Flags: review?
Attached patch bug1027435.patch (obsolete) — Splinter Review
Rolled the previous patch of two files into the same one file.
Attachment #8443103 - Attachment is obsolete: true
Attachment #8443103 - Flags: review?
Attachment #8443129 - Flags: review?
Comment on attachment 8443129 [details] [diff] [review]
bug1027435.patch

Review of attachment 8443129 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed

::: .gitignore
@@ +28,4 @@
>  
>  *.db
>  *.log
> +.vagrant/
\ No newline at end of file

missing newline

::: Vagrantfile
@@ +1,2 @@
> +Vagrant.configure("2") do |config|
> +  config.vm.box = "hashicorp/precise64"

Worth a comment that this is "just a basic box", so no one has to worry later if they switch it out.
Attachment #8443129 - Flags: review? → review+
Attached patch bug1027435.patch (obsolete) — Splinter Review
Using global variable in ruby instead, added extra line to .gitignore and comment about vagrant box
Attachment #8443129 - Attachment is obsolete: true
Attachment #8443135 - Flags: review?
Attached patch bug1027435.patchSplinter Review
Added comments to README
Attachment #8443135 - Attachment is obsolete: true
Attachment #8443135 - Flags: review?
It's working well! Pull the repo, cd into it, run vagrant up and visit http://127.0.0.1:5000/ to see it work!
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Great, thanks John, I tried it this morning and it worked fine.
You need to log in before you can comment on or make changes to this bug.