Closed
Bug 1027435
Opened 10 years ago
Closed 10 years ago
Create a Vagrantfile for Ship It
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zeller, Assigned: zeller)
Details
Attachments
(1 file, 3 obsolete files)
1.88 KB,
patch
|
Details | Diff | Splinter Review |
Create a Vagrantfile for the Ship It app found here http://git.mozilla.org/?p=build/release-kickoff.git
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → johnlzeller
Assignee | ||
Comment 1•10 years ago
|
||
This patch adds a Vagrantfile and shell script to the base of the release-kickoff (ship it app) repo.
Attachment #8443103 -
Flags: review?
Assignee | ||
Comment 2•10 years ago
|
||
Rolled the previous patch of two files into the same one file.
Attachment #8443103 -
Attachment is obsolete: true
Attachment #8443103 -
Flags: review?
Attachment #8443129 -
Flags: review?
Comment 3•10 years ago
|
||
Comment on attachment 8443129 [details] [diff] [review] bug1027435.patch Review of attachment 8443129 [details] [diff] [review]: ----------------------------------------------------------------- r+ with comments addressed ::: .gitignore @@ +28,4 @@ > > *.db > *.log > +.vagrant/ \ No newline at end of file missing newline ::: Vagrantfile @@ +1,2 @@ > +Vagrant.configure("2") do |config| > + config.vm.box = "hashicorp/precise64" Worth a comment that this is "just a basic box", so no one has to worry later if they switch it out.
Attachment #8443129 -
Flags: review? → review+
Assignee | ||
Comment 4•10 years ago
|
||
Using global variable in ruby instead, added extra line to .gitignore and comment about vagrant box
Attachment #8443129 -
Attachment is obsolete: true
Attachment #8443135 -
Flags: review?
Assignee | ||
Comment 5•10 years ago
|
||
Added comments to README
Attachment #8443135 -
Attachment is obsolete: true
Attachment #8443135 -
Flags: review?
Assignee | ||
Comment 6•10 years ago
|
||
It's working well! Pull the repo, cd into it, run vagrant up and visit http://127.0.0.1:5000/ to see it work!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 7•10 years ago
|
||
Great, thanks John, I tried it this morning and it worked fine.
You need to log in
before you can comment on or make changes to this bug.
Description
•