1027444 - Tokenserver JSON summary logs code=200 for error responses

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Token, defect)

Description

[Ryan Kelly [:rfkelly]]

As noticed during loadtesting in Bug 1014496, this actually produces a 503 response but the summary log line says 200:

{"code": 200, "v": 1, "pid": 3434, "agent": "python-requests/2.2.1 CPython/2.7.3 Linux/3.5.0-23-generic", "token.assertion.verify_failure": 1, "path": "https://token.stage.mozaws.net/1.0/sync/1.5", "remoteAddressChain": ["54.245.44.231", "10.198.137.229", "127.0.0.1"], "request_time": 0.04247593879699707, "hostname": "ip-10-97-158-44", "name": "mozsvc.metrics", "token.assertion.connection_error": 1, "tokenserver.assertion.verify": 0.041944980621337891, "time": "2014-06-19T00:48:01.719310Z", "method": "GET", "op": "mozsvc.metrics"}

It's probably due to tokenserver raising an error object rather than returning an error response.

Comment 1

[James Bonacci [:jbonacci]]

Do we want an update here now that 1.2.9 is about to go to Production?

Comment 2

[James Bonacci [:jbonacci]]

Stage and Production are out the door:
Stage Deploy: bug 1014496
Prod Deploy: bug 1027899

so, we can save this work for the next round...

Comment 3

[Ryan Kelly [:rfkelly]]

Attachment: mozsvc-fix-summary-status-code.diff

Fortunately a pretty trivial fix

Comment 4

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/mozservices/commit/e00e1b68130423ad98d0f6185655bde650443da8