The current notification.js and its tests mixed the code for LockScreen and the statusbar together. As a plan to pull LockScreen out and as an app, the current implementation would be a trouble. So I want to split it into 2 parts: notification_lockscreen.js notificaiont_statusbar.js Relevante tests would also be refactored, too.
Sorry, typo: notificaiont_statusbar.js -> notification_utilitytray.js
Comment on attachment 8450065 [details] [review] Patch Since it passed all tests excepted one unit test which passed on my local console, and another intermittent Gi failure, I set the review flag first. Another reason is reviewing may require me to modify the patch, too, so waiting a perfect CI result may be not so necessary.
Attachment #8450065 - Flags: review?(alive)
Comment on attachment 8450065 [details] [review] Patch Basically no concern if all tests pass.
Attachment #8450065 - Flags: review?(alive) → review+
TBPL failed with timeout and intermittent integration tests: https://tbpl.mozilla.org/?rev=2fb7ff9ebe9d9b6236ade2a7b82ea60df84f4963&tree=Gaia-Try And Travis only failed at those intermittent tests: https://travis-ci.org/mozilla-b2g/gaia/builds/29470521 So I would land the patch and to see if there are more errors.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Hi guys! I git reverted https://github.com/snowmantw/gaia/commit/61ab5bf41df531eaee8dcbf2511ddd5608e2e9d7 since it was causing bug 1036378. If you need further information please do not hesitate to contact me ;) Thanks!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Okay, so now that this has been backed out, I will restart (again) my patch for bug 1030063. Could you please wait that I land this and rebase onto this ? Thanks!
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago → 4 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.