1027471 - [LockScreen][System] Split notification.js into LockScreen and System parts

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System::Lockscreen, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

The current notification.js and its tests mixed the code for LockScreen and the statusbar together. As a plan to pull LockScreen out and as an app, the current implementation would be a trouble. So I want to split it into 2 parts:

notification_lockscreen.js
notificaiont_statusbar.js

Relevante tests would also be refactored, too.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Sorry, typo:

notificaiont_statusbar.js ->
notification_utilitytray.js

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8450065 [details] [review]
Patch

Since it passed all tests excepted one unit test which passed on my local console, and another intermittent Gi failure, I set the review flag first. Another reason is reviewing may require me to modify the patch, too, so waiting a perfect CI result may be not so necessary.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8450065 [details] [review]
Patch

Basically no concern if all tests pass.

Comment 5

[Greg Weng [:snowmantw][:gweng][:λ]]

TBPL failed with timeout and intermittent integration tests:

https://tbpl.mozilla.org/?rev=2fb7ff9ebe9d9b6236ade2a7b82ea60df84f4963&tree=Gaia-Try

And Travis only failed at those intermittent tests:

https://travis-ci.org/mozilla-b2g/gaia/builds/29470521

So I would land the patch and to see if there are more errors.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/c394b7b4205b6f1a6ca44915fc08650f3ad127ec

Comment 7

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I git reverted https://github.com/snowmantw/gaia/commit/61ab5bf41df531eaee8dcbf2511ddd5608e2e9d7 since it was causing bug 1036378. If you need further information please do not hesitate to contact me ;) Thanks!

Comment 8

[:gerard-majax]

Okay, so now that this has been backed out, I will restart (again) my patch for bug 1030063. Could you please wait that I land this and rebase onto this ?

Thanks!

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

No more emotional questioning on IRC and the attitude that "I can conflict others' patch while mime must not be conflicted". So I would do no more refactoring in System but only minimal patches that to help LockScreen works in the future, unless there is some clear requests from leaders. After all, it's not me who even is not a peer to leave those nasty 1K/2K LOCS JavaScript files, or the brutal strong coupling code, totally un-isolated unit tests, un-robust 'init' functions, and the code show contributors who were too b(l)u(a)s(z)y to write code following some basic OOP principles.

Anyone who doubt that can browser the log, to see today's history.

And I would close this bug. Do anything you all want to do.