1027501 - print-manifest-dirs.py run-time error: UnboundLocalError: local variable 'testURLs' referenced before assignment

Status: RESOLVED DUPLICATE of bug 1027215

(Core :: Graphics, defect)

Description

[u459114]

Refer to error log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=42022083&tree=Try&full=1#error0
  UnboundLocalError: local variable 'testURLs' referenced before assignment

Source code:
http://dxr.mozilla.org/mozilla-central/source/layout/tools/reftest/print-manifest-dirs.py
If all the conditions between #41~#51 do not match, using testURLs at #53 issues an UnboundLocalError error.

PS
Not quite sure whether this bug belongs to gfx, but since I found it while debugging a gfx issue, assign this as Graphic bug first.

Comment 1

[u459114]

According to bug 1000722 comment 35, we may improve error handling in parseManifest here.
"<<<<<<< local" is a string that parseManifest does not expect.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8) (Away, back on Mar 24)]

We might add an "else" statement before "for u in testURLs:", and raise an customized exception such as ManifestParseError to print file name, line number, and the content of that line.

Comment 3

[u459114]

Attachment: bug_1027501

Comment 4

[u459114]

Comment on attachment 8442701 [details] [diff] [review]
bug_1027501

Review of attachment 8442701 [details] [diff] [review]:
-----------------------------------------------------------------

Hi TY,
How about this one?

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8) (Away, back on Mar 24)]

Comment on attachment 8442701 [details] [diff] [review]
bug_1027501

Review of attachment 8442701 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/reftest/print-manifest-dirs.py
@@ +49,5 @@
>      elif items[0] == "load" or items[0] == "script":
>        testURLs = [items[1]]
>      elif items[0] == "==" or items[0] == "!=":
>        testURLs = items[1:3]
> +    else

Syntax error. It should be "else:"

Comment 6

[u459114]

Attachment: bug_1027501

Oops...grammar error

Comment 7

[u459114]

Attachment: bug_1027501

Comment 8

[Ting-Yu Lin [:TYLin] (PST, UTC-8) (Away, back on Mar 24)]

Comment on attachment 8442723 [details] [diff] [review]
bug_1027501

Review of attachment 8442723 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. However, the patch does not have a e-mail address.

Comment 9

[u459114]

Attachment: Print error message while input string syntax is not right

Comment 10

[u459114]

Attachment: Print error message while input string syntax is not right

Comment 11

[u459114]

Comment on attachment 8442728 [details] [diff] [review]
Print error message while input string syntax is not right

Hi dbaron,
Please help to review this patch, thanks

Comment 12

[Ting-Yu Lin [:TYLin] (PST, UTC-8) (Away, back on Mar 24)]

It seems gps is going to rewrite print-manifest-dirs.py in bug 1027215. I hope the new version will have better error handling.

Comment 13

[u459114]

Yes, I saw you comment in attachment 8442961 [details] [diff] [review]. Close this one