1027514 - [B2G][RIL][MMI] Add marionette test cases for callforwarding MMI code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Edgar Chen [:edgar]]

Now emulator supports setting/getting callforwarding, we could write some test cases for callforwarding MMI code.

Comment 1

[Edgar Chen [:edgar]]

Attachment: Patch, v1

Comment 2

[Edgar Chen [:edgar]]

Attachment: Patch, v2

Comment 3

[Edgar Chen [:edgar]]

Attachment: Patch, v3

Comment 4

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8445677 [details] [diff] [review]
Patch, v3

Review of attachment 8445677 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you.

::: dom/mobileconnection/tests/marionette/test_mobile_mmi_call_forwarding.js
@@ +123,5 @@
> +      reason: reason,
> +      action: MozMobileConnection.CALL_FORWARD_ACTION_ERASURE
> +    };
> +    promise =
> +      promise.then(() => setCallForwardingOption(options).then(null, () => {}));

I am not sure I got the point of having "then(null, () => {})" appended.

Comment 5

[Edgar Chen [:edgar]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #4)
> Comment on attachment 8445677 [details] [diff] [review]
> Patch, v3
> 
> Review of attachment 8445677 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thank you.
> 
> ::: dom/mobileconnection/tests/marionette/test_mobile_mmi_call_forwarding.js
> @@ +123,5 @@
> > +      reason: reason,
> > +      action: MozMobileConnection.CALL_FORWARD_ACTION_ERASURE
> > +    };
> > +    promise =
> > +      promise.then(() => setCallForwardingOption(options).then(null, () => {}));
> 
> I am not sure I got the point of having "then(null, () => {})" appended.

It is because emulator doesn't support CALL_FORWARD_REASON_ALL_* yet [1], we catch the reject here in order to avoid impact the test result. I guess I can add some comments here to make things clearer.

Thank you.

[1] https://github.com/mozilla-b2g/platform_external_qemu/blob/3326b51017252e09ccdd715dec6c5e12a7d1ecfe/telephony/android_modem.c#L2629-L2635

Comment 6

[Edgar Chen [:edgar]]

Attachment: Patch, v4, r=hsinyi

Add some comments for comment #5.

Comment 7

[Edgar Chen [:edgar]]

Try result: https://tbpl.mozilla.org/?tree=Try&rev=edea5cd587cc

Comment 8

[Edgar Chen [:edgar]]

https://hg.mozilla.org/integration/b2g-inbound/rev/8357d7f11d20

Comment 9

[Edgar Chen [:edgar]]

http://hg.mozilla.org/mozilla-central/rev/8357d7f11d20

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8357d7f11d20