Closed Bug 1027573 Opened 7 years ago Closed 7 years ago
Crash when measuring memory in about:memory while using Web Audio
STR: - Open http://jsfiddle.net/dXjK5/ - Click the "Play" icon so that the demo runs - Open another tab, and type in "about:memory" - Click the "Measure" button I see a crash half the time (I tried a couple times), so this seem to be intermittent. The above demo creates a lot of nodes, which may show the issue. Soccoro report: https://crash-stats.mozilla.com/report/index/a6bb74e5-cc2f-488b-a060-0b2b82140619#details. This seem to be a simple nullptr deref in SizeOf* code.
This patch adds a check for a valid AudioNode before dereferencing it. It also adds support for reporting web audio memory usage even if we don't know the node type.
Attachment #8443161 - Flags: review?(roc)
Attachment #8443161 - Flags: review?(roc) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
How hard would it be to modify toolkit/components/aboutmemory/tests/test_memoryReporters.xul to test for this change?
You need to log in before you can comment on or make changes to this bug.