1027573 - Crash when measuring memory in about:memory while using Web Audio

Status: RESOLVED FIXED

(Core :: Web Audio, defect)

Description

[Paul Adenot (:padenot)]

STR:
- Open http://jsfiddle.net/dXjK5/
- Click the "Play" icon so that the demo runs
- Open another tab, and type in "about:memory"
- Click the "Measure" button

I see a crash half the time (I tried a couple times), so this seem to be intermittent. The above demo creates a lot of nodes, which may show the issue.

Soccoro report: https://crash-stats.mozilla.com/report/index/a6bb74e5-cc2f-488b-a060-0b2b82140619#details. This seem to be a simple nullptr deref in SizeOf* code.

Comment 1

[Eric Rahm [:erahm]]

Attachment: Crash when measuring memory in about:memory while using Web Audio

This patch adds a check for a valid AudioNode before dereferencing it. It also adds support for reporting web audio memory usage even if we don't know the node type.

Comment 2

[Eric Rahm [:erahm]]

try: https://tbpl.mozilla.org/?tree=Try&rev=754a9c0c6332

Comment 3

[Eric Rahm [:erahm]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6020ff9edd30

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6020ff9edd30

Comment 5

[Nicholas Nethercote [inactive]]

How hard would it be to modify toolkit/components/aboutmemory/tests/test_memoryReporters.xul to test for this change?