1027601 - Allocate TextureClient when it is created rather than as a second step.

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

The possibility of having unallocated TextureClients is not useful and sometimes create bugs if we don't check that allocation happens properly at best in makes the code more complex than it should be. let's merge the creation and allocation steps.

Comment 1

[Nicolas Silva [:nical]]

Attachment: Part 1) CreateTextureClientForDrawing

More to come.

Comment 2

[Nicolas Silva [:nical]]

Attachment: Part 2) Create and Allocate the TextureClient in one step in SharedPlanarYCbCrImage (+ a bit of cleanup)

Comment 3

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e072a46f0b6a
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef24cd472cfb

Comment 4

[Nicolas Silva [:nical]]

Fix a rebasing mistake: https://hg.mozilla.org/integration/mozilla-inbound/rev/ba77f00867e8

Comment 5

[Gary [:streetwolf52]]

I suppose you are already aware that this patch caused many of my add-ons to stop working.

Comment 6

[Carsten Book [:Tomcat]]

sorry had to backout this changes for causing crashes like https://tbpl.mozilla.org/php/getParsedLog.php?id=43422810&tree=Mozilla-Inbound

Comment 7

[Gary [:streetwolf52]]

I just wanted to mention the add-ons breakage in case it's a different problem than the one you backed out this patch for.

Comment 8

[Nicolas Silva [:nical]]

Doh, try was green before the rebase :(

Comment 9

[Nicolas Silva [:nical]]

Fixed and relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dacd89b4ce4
https://hg.mozilla.org/integration/mozilla-inbound/rev/31c5ac29e510

try push:
https://tbpl.mozilla.org/?tree=Try&rev=1c0985ffc96a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1dacd89b4ce4
https://hg.mozilla.org/mozilla-central/rev/31c5ac29e510