Closed Bug 1027601 Opened 7 years ago Closed 7 years ago

Allocate TextureClient when it is created rather than as a second step.

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla33

People

(Reporter: nical, Assigned: nical, Mentored)

References

Details

Attachments

(2 files)

The possibility of having unallocated TextureClients is not useful and sometimes create bugs if we don't check that allocation happens properly at best in makes the code more complex than it should be. let's merge the creation and allocation steps.
Blocks: 1027599
More to come.
Assignee: nobody → nical.bugzilla
Attachment #8442963 - Flags: review?(sotaro.ikeda.g)
Blocks: 990924
No longer blocks: 1027599
Mentor: nical.bugzilla
Attachment #8442963 - Flags: review?(sotaro.ikeda.g) → review+
Attachment #8444125 - Flags: review?(sotaro.ikeda.g) → review+
I suppose you are already aware that this patch caused many of my add-ons to stop working.
sorry had to backout this changes for causing crashes like https://tbpl.mozilla.org/php/getParsedLog.php?id=43422810&tree=Mozilla-Inbound
I just wanted to mention the add-ons breakage in case it's a different problem than the one you backed out this patch for.
Doh, try was green before the rebase :(
https://hg.mozilla.org/mozilla-central/rev/1dacd89b4ce4
https://hg.mozilla.org/mozilla-central/rev/31c5ac29e510
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in before you can comment on or make changes to this bug.