crash in java.net.MalformedURLException: Unknown protocol: textstyle at java.net.URL.<init>(URL.java)

RESOLVED FIXED in mozilla33

Status

()

Core
Widget: Android
--
critical
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: aaronmt, Assigned: blassey)

Tracking

({crash})

33 Branch
mozilla33
All
Android
crash
Points:
---

Firefox Tracking Flags

(firefox33- affected)

Details

(crash signature, URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
This bug was filed from the Socorro interface and is 
report bp-64dc545e-bd01-4124-bc45-f53cc2140618.
=============================================================

ava.net.MalformedURLException: Unknown protocol: textstyle
	at java.net.URL.<init>(URL.java:182)
	at java.net.URL.<init>(URL.java:125)
	at org.mozilla.gecko.GeckoAppShell.getConnection(GeckoAppShell.java:2722)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:358)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:176)
(Reporter)

Updated

4 years ago
Component: General → Widget: Android
Product: Firefox for Android → Core
Version: Firefox 33 → 33 Branch
(Reporter)

Updated

4 years ago
(Reporter)

Updated

4 years ago
tracking-firefox33: --- → ?
Created attachment 8442821 [details] [diff] [review]
no_throw_getConnection.patch

the right thing to do here is bug 1027642 IMO, but we can get this landed more quickly
Assignee: nobody → blassey.bugs
Attachment #8442821 - Flags: review?(snorp)
Comment on attachment 8442821 [details] [diff] [review]
no_throw_getConnection.patch

Review of attachment 8442821 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +2719,5 @@
> +            int colon = spec.indexOf(':');
> +            if (colon == -1 || colon > spec.indexOf('/')) {
> +                spec = spec.replaceFirst("/", ":/");
> +            }
> +        } catch(Exception ex) {

It's typically bad form to catch all exceptions, but I guess it makes sense in this JNI type of use case.
Attachment #8442821 - Flags: review?(snorp) → review+
https://hg.mozilla.org/mozilla-central/rev/e4d54debfb2b
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
tracking-firefox33: ? → -
You need to log in before you can comment on or make changes to this bug.