1027634 - crash in java.net.MalformedURLException: Unknown protocol: textstyle at java.net.URL.<init>(URL.java)

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Aaron Train [:aaronmt]]

This bug was filed from the Socorro interface and is 
report bp-64dc545e-bd01-4124-bc45-f53cc2140618.
=============================================================

ava.net.MalformedURLException: Unknown protocol: textstyle
	at java.net.URL.<init>(URL.java:182)
	at java.net.URL.<init>(URL.java:125)
	at org.mozilla.gecko.GeckoAppShell.getConnection(GeckoAppShell.java:2722)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:358)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:176)

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: no_throw_getConnection.patch

the right thing to do here is bug 1027642 IMO, but we can get this landed more quickly

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8442821 [details] [diff] [review]
no_throw_getConnection.patch

Review of attachment 8442821 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +2719,5 @@
> +            int colon = spec.indexOf(':');
> +            if (colon == -1 || colon > spec.indexOf('/')) {
> +                spec = spec.replaceFirst("/", ":/");
> +            }
> +        } catch(Exception ex) {

It's typically bad form to catch all exceptions, but I guess it makes sense in this JNI type of use case.

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e4d54debfb2b