1027645 - Eliminate all nsRenderingContext::AppUnitsPerDevPixel() callers and all non-propagating nsRenderingContext::DeviceContext() callers

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

This patch eliminate all nsRenderingContext::AppUnitsPerDevPixel() callers and all non-propagating nsRenderingContext::DeviceContext() callers. I want this now mostly in order to have an aPresContext in DrawImageInternal() so that I can easily fix bug 1003505.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8442824 [details] [diff] [review]
patch

Review of attachment 8442824 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/base/FrameLayerBuilder.cpp
@@ +3569,5 @@
>  {
>    bool snap;
>    nsRect appUnitBounds = aItem->GetBounds(aBuilder, &snap);
>    gfxRect bounds(appUnitBounds.x, appUnitBounds.y, appUnitBounds.width, appUnitBounds.height);
> +  bounds.ScaleInverse(aPresContext->DeviceContext()->AppUnitsPerDevPixel());

Just aPresContext->AppUnitsPerDevPixel()

::: layout/base/nsLayoutUtils.cpp
@@ +5030,5 @@
>    if (aDest.Contains(aFill)) {
>      aImageFlags |= imgIContainer::FLAG_CLAMP;
>    }
> +  int32_t appUnitsPerDevPixel =
> +   aPresContext->DeviceContext()->AppUnitsPerDevPixel();

ditto

@@ +5062,5 @@
>                                  const nsPoint&       aAnchor,
>                                  const nsRect&        aDirty)
>  {
> +  int32_t appUnitsPerDevPixel =
> +    aPresContext->DeviceContext()->AppUnitsPerDevPixel();

ditto

@@ +5149,5 @@
>      // We choose a size for vector images that emulates a raster image which
>      // is perfectly sized for the destination rect: each pixel in the image
>      // maps exactly to a single pixel on-screen.
> +    nscoord appUnitsPerDevPx =
> +      aPresContext->DeviceContext()->AppUnitsPerDevPixel();

ditto

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d2e1d54476

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/c6d2e1d54476