Closed Bug 1027651 Opened 5 years ago Closed 3 years ago

Fix comment for XRE_UPDATE_ROOT_DIR

Categories

(Toolkit :: Startup and Profile System, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla49
Tracking Status
firefox49 --- fixed

People

(Reporter: spohl, Assigned: spohl)

References

Details

Attachments

(1 file, 5 obsolete files)

This should land at the same time (or shortly after) bug 394984.
Attached patch Patch (obsolete) — Splinter Review
Attachment #8442837 - Flags: review?(robert.strong.bugs)
Comment on attachment 8442837 [details] [diff] [review]
Patch

I think I'd like to keep the comment for what this will be on Windows and add comments for new platforms. What do you think?
Attachment #8442837 - Flags: review?(robert.strong.bugs)
Attached patch Patch (obsolete) — Splinter Review
Of course! Not sure what I was thinking.
Attachment #8442837 - Attachment is obsolete: true
Attachment #8452423 - Flags: review?(robert.strong.bugs)
Component: Installer → Startup and Profile System
Product: Firefox → Toolkit
Attached patch Patch (obsolete) — Splinter Review
Attachment #8452423 - Attachment is obsolete: true
Attachment #8452452 - Flags: review?(robert.strong.bugs)
Comment on attachment 8452452 [details] [diff] [review]
Patch

The Windows comment is incorrect in that it doesn't fail and has a couple of additional fallbacks.
http://mxr.mozilla.org/mozilla-central/source/toolkit/xre/nsXREDirProvider.cpp#1067

r=me with that and thanks!
Attachment #8452452 - Flags: review?(robert.strong.bugs) → review+
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> Comment on attachment 8452452 [details] [diff] [review]
> Patch
> 
> The Windows comment is incorrect in that it doesn't fail and has a couple of
> additional fallbacks.
for clarity, doesn't typically fail
Attached patch Patch (obsolete) — Splinter Review
Setting this to r? one more time for a second pair of eyes.
Attachment #8452452 - Attachment is obsolete: true
Attachment #8453832 - Flags: review?(robert.strong.bugs)
Attached patch Patch (obsolete) — Splinter Review
Missed a mistake in two of the paths. Sorry about the bugspam.
Attachment #8453832 - Attachment is obsolete: true
Attachment #8453832 - Flags: review?(robert.strong.bugs)
Attachment #8453834 - Flags: review?(robert.strong.bugs)
Attachment #8453834 - Flags: review?(robert.strong.bugs) → review+
Since bug 394984 is unlikely to land in the next two weeks I'm unassigning myself for now.
Assignee: spohl.mozilla.bugs → nobody
Status: ASSIGNED → NEW
Mentor: robert.strong.bugs
Whiteboard: [good first bug]
Mentor: robert.strong.bugs
Whiteboard: [good first bug]
Assignee: nobody → spohl.mozilla.bugs
Attached patch PatchSplinter Review
Updated for current trunk, carrying over r+.
Attachment #8453834 - Attachment is obsolete: true
Attachment #8753631 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/ead4c5f8ae57
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
You need to log in before you can comment on or make changes to this bug.