1027657 - Allow pushing Instantbird-only changes on a closed c-c- tree

Status: RESOLVED FIXED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[aleth [:aleth]]

Since https://hg.mozilla.org/build/buildbotcustom/rev/7590da3dfbbc, TB builds are no longer triggered by c-c checkins that only touch im/. Standard8 suggested we update the tree closure exceptions to reflect this.

Comment 1

[aleth [:aleth]]

Attachment: closedtree.diff

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 8442849 [details] [diff] [review]
closedtree.diff

Review of attachment 8442849 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/hgcustom/hghooks/file/0ee2f8335098/mozhghooks/treeclosure_comm_central.py#l41
def checkJsonTreeState(repo, repoName, appName):

will fail for all instantbird landings if this is applied. Meaning it will *always* be closed tree. because it tries to do: url = "%s/%s-%s?format=json" % (treestatus_base_url, name, appName)

I'd rather a "silently ignore" instantbird, unless there is a strong compelling reason to not?


You can achieve that desire by not munging the "app" dict, and changing `apps['instantbird'] = True` to `pass  # ignore instantbird for tree closure reasons`

Comment 3

[aleth [:aleth]]

Attachment: closedtree.diff 2

(In reply to Justin Wood (:Callek) from comment #2)

Thanks for the quick review!

> will fail for all instantbird landings if this is applied. Meaning it will
> *always* be closed tree. because it tries to do: url =
> "%s/%s-%s?format=json" % (treestatus_base_url, name, appName)
> 
> I'd rather a "silently ignore" instantbird, unless there is a strong
> compelling reason to not?

I assumed that in copying what was done for seamonkey, a treestatus would have to be added for Instantbird too, but your suggestion is much simpler!

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8445114 [details] [diff] [review]
closedtree.diff 2

Review of attachment 8445114 [details] [diff] [review]:
-----------------------------------------------------------------

Will need to land and have an IT bug to deploy.

Comment 5

[aleth [:aleth]]

(In reply to Justin Wood (:Callek) from comment #4)
> Will need to land and have an IT bug to deploy.

What's the right category to file this bug in?

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/hgcustom/hghooks/rev/1da6c5dff8e2

Comment 7

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/411870c96b45