The default bug view has changed. See this FAQ.

Allow pushing Instantbird-only changes on a closed c-c- tree

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: aleth, Assigned: aleth)

Tracking

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Since https://hg.mozilla.org/build/buildbotcustom/rev/7590da3dfbbc, TB builds are no longer triggered by c-c checkins that only touch im/. Standard8 suggested we update the tree closure exceptions to reflect this.
(Assignee)

Comment 1

3 years ago
Created attachment 8442849 [details] [diff] [review]
closedtree.diff
Attachment #8442849 - Flags: review?(bugspam.Callek)
Comment on attachment 8442849 [details] [diff] [review]
closedtree.diff

Review of attachment 8442849 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/hgcustom/hghooks/file/0ee2f8335098/mozhghooks/treeclosure_comm_central.py#l41
def checkJsonTreeState(repo, repoName, appName):

will fail for all instantbird landings if this is applied. Meaning it will *always* be closed tree. because it tries to do: url = "%s/%s-%s?format=json" % (treestatus_base_url, name, appName)

I'd rather a "silently ignore" instantbird, unless there is a strong compelling reason to not?


You can achieve that desire by not munging the "app" dict, and changing `apps['instantbird'] = True` to `pass  # ignore instantbird for tree closure reasons`
Attachment #8442849 - Flags: review?(bugspam.Callek) → review-
(Assignee)

Comment 3

3 years ago
Created attachment 8445114 [details] [diff] [review]
closedtree.diff 2

(In reply to Justin Wood (:Callek) from comment #2)

Thanks for the quick review!

> will fail for all instantbird landings if this is applied. Meaning it will
> *always* be closed tree. because it tries to do: url =
> "%s/%s-%s?format=json" % (treestatus_base_url, name, appName)
> 
> I'd rather a "silently ignore" instantbird, unless there is a strong
> compelling reason to not?

I assumed that in copying what was done for seamonkey, a treestatus would have to be added for Instantbird too, but your suggestion is much simpler!
Attachment #8442849 - Attachment is obsolete: true
Attachment #8445114 - Flags: review?(bugspam.Callek)
Comment on attachment 8445114 [details] [diff] [review]
closedtree.diff 2

Review of attachment 8445114 [details] [diff] [review]:
-----------------------------------------------------------------

Will need to land and have an IT bug to deploy.
Attachment #8445114 - Flags: review?(bugspam.Callek) → review+
(Assignee)

Comment 5

3 years ago
(In reply to Justin Wood (:Callek) from comment #4)
> Will need to land and have an IT bug to deploy.

What's the right category to file this bug in?
Keywords: checkin-needed
https://hg.mozilla.org/hgcustom/hghooks/rev/1da6c5dff8e2
Keywords: checkin-needed
(Assignee)

Updated

3 years ago
Depends on: 1031348
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Comment 7

3 years ago
https://hg.mozilla.org/hgcustom/version-control-tools/rev/411870c96b45
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.